Bug 519236

Summary:	Review Request: plexus-resources - Plexus Resource Manager
Product:	[Fedora] Fedora	Reporter:	Andrew Overholt <overholt>
Component:	Package Review	Assignee:	Jeff Johnston <jjohnstn>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, jjohnstn, notting
Target Milestone:	---	Flags:	jjohnstn: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-08-27 15:19:37 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Andrew Overholt 2009-08-25 19:23:18 UTC

Spec URL: http://overholt.fedorapeople.org/plexus-resources.spec
SRPM URL: http://overholt.fedorapeople.org/plexus-resources-1.0-0.1.a4.5.fc11.src.rpm

Description:
The Plexus project seeks to create end-to-end developer tools for
writing applications. At the core is the container, which can be
embedded or for a full scale application server. There are many
reusable components for hibernate, form processing, jndi, i18n,
velocity, etc. Plexus also includes an application server which
is like a J2EE application server, without all the baggage.

Comment 1 Andrew Overholt 2009-08-25 19:24:03 UTC

Old pre-review request for this package:  bug #500264.

Comment 2 Jeff Johnston 2009-08-25 20:31:34 UTC

rpmlint successful

Comments:

1. Packaging naming convention has the number incrementing ahead of the
   alphatag.  So release should be 0.2.a4 and then 0.3.a4 etc..

2. Javadoc description should not reference itself (use API documentation for
   xxx)

3. No %doc files

4. post and postun sections are maven-only.  Is this a problem since with_maven
   is 0?
   
5. defattr non-standard.

Comment 3 Andrew Overholt 2009-08-26 15:06:29 UTC

(In reply to comment #2)
> 1. Packaging naming convention has the number incrementing ahead of the
>    alphatag.  So release should be 0.2.a4 and then 0.3.a4 etc..

Oops, fixed.

> 2. Javadoc description should not reference itself (use API documentation for
>    xxx)

Fixed.

> 3. No %doc files

There's nothing to mark %doc.

> 4. post and postun sections are maven-only.  Is this a problem since with_maven
>    is 0?

No.

> 5. defattr non-standard.  

Fixed.

Updated spec and SRPM:

http://overholt.fedorapeople.org/plexus-resources.spec
http://overholt.fedorapeople.org/plexus-resources-1.0-0.2.a4.fc11.src.rpm

Comment 4 Jeff Johnston 2009-08-26 18:01:48 UTC

[jjohnstn@vermillion noarch]$ rpmlint plexus-resources-*
plexus-resources.noarch: W: no-documentation
plexus-resources.noarch: W: non-conffile-in-etc /etc/maven/fragments/plexus-resources

Built successfully.  Package approved.

Comment 5 Andrew Overholt 2009-08-26 18:13:45 UTC

New Package CVS Request
=======================
Package Name: plexus-resources
Short Description: Plexus Resource Manager
Owners: overholt, akurtakov
Branches: 
InitialCC:

Comment 6 Kevin Fenzi 2009-08-26 22:16:30 UTC

cvs done.

Comment 7 Andrew Overholt 2009-08-27 15:19:37 UTC

Built:

http://koji.fedoraproject.org/koji/taskinfo?taskID=1638868