Bug 519724

Summary: admin.cgi crashes when modifying class
Product: [Fedora] Fedora Reporter: Jiri Popelka <jpopelka>
Component: cupsAssignee: Tim Waugh <twaugh>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: 11CC: jpopelka, twaugh
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 1.4.2-7.fc11 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-12-01 04:18:45 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Proposed patch none

Description Jiri Popelka 2009-08-27 15:00:13 UTC
Description of problem:
I can't modify class in cups web interface. Whenever I press
"Modify Class" button I get "500 Internal Server Error".

Version-Release number of selected component (if applicable):
cups-1.4-0.rc1.15.fc11.x86_64

How reproducible:
Always

Steps to Reproduce:
1. http://localhost:631/admin
2. Add Class (no members needed)
3. http://localhost:631/classes
4. Click on class name, Administration -> Modify Class
5. Press "Modify Class" button
  
Actual results:
500 Internal Server Error

Expected results:
Class has been modified successfully.

Additional info:
/var/log/cups/error_log contains
(/usr/lib/cups/cgi-bin/admin.cgi) crashed on signal 11!

Comment 1 Jiri Popelka 2009-08-27 15:01:28 UTC
Created attachment 358885 [details]
Proposed patch

admin.c crashes on line 640
   for (ptr = name; *ptr; ptr ++)
because name is NULL pointer.

The problem is that form variable PRINTER_NAME is not defined because
there's missing line
<INPUT TYPE="HIDDEN" NAME="PRINTER_NAME" VALUE="{printer_name}">
in
templates/modify-class.tmpl

Comment 2 Tim Waugh 2009-08-27 15:32:44 UTC
Nice catch!  Reported upstream.

Comment 3 Tim Waugh 2009-10-05 13:36:36 UTC
This fix is included in cups-1.4.1-2.fc11.

Comment 4 Fedora Update System 2009-10-27 16:39:18 UTC
cups-1.4.1-7.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/cups-1.4.1-7.fc11

Comment 5 Fedora Update System 2009-10-29 03:02:28 UTC
cups-1.4.1-7.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update cups'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-10891

Comment 6 Fedora Update System 2009-11-04 12:39:23 UTC
cups-1.4.1-8.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update cups'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-10891

Comment 7 Fedora Update System 2009-11-11 15:01:40 UTC
cups-1.4.2-1.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update cups'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-10891

Comment 8 Fedora Update System 2009-11-18 14:15:04 UTC
cups-1.4.2-5.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update cups'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-10891

Comment 9 Fedora Update System 2009-11-20 05:23:26 UTC
cups-1.4.2-7.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update cups'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-10891

Comment 10 Fedora Update System 2009-12-01 04:17:31 UTC
cups-1.4.2-7.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.