Bug 520343
| Summary: | Review Request: clc - command line client for MUDs | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sean Middleditch <sean> |
| Component: | Package Review | Assignee: | Jan Klepek <jan.klepek> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, jan.klepek, notting |
| Target Milestone: | --- | Flags: | jan.klepek:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-10-03 00:41:59 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 515832 | ||
| Bug Blocks: | |||
|
Description
Sean Middleditch
2009-08-31 00:12:32 UTC
Spec URL: http://middleditch.us/sean/clc.spec SRPM URL: http://middleditch.us/sean/clc-0.01-2.fc12.src.rpm Fixed a typo I just caught in the source URL for the spec file. Updated to release -2 and added a changelog note. Now that libtelnet is in F12, I tried a scratch build on Koji. That made it clear that I forgot some build requires on packages I had installed on my local machine (Koji is damn handy that way). Updated to 0.01-3 with the build requires added. Verified it works on Koji now. Spec URL: http://middleditch.us/sean/clc.spec SRPM URL: http://middleditch.us/sean/clc-0.01-3.fc12.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=1674042 1] i didn't see there usage of fedora compiler flags. https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags 2] md5sum of download from SOURCE is different from tar which is in src.rpm b6043dececbaa61e8a3b26a2bda33d38 clc-0.01.tar.gz ed6d17913a6f8e1d9db4a210f5edef34 SOURCES/clc-0.01.tar.gz 3] macros usage use only one style of macros or variable. not both in one spec file. so you eiter replace variables with corresponding macros or macros with variables. http://fedoraproject.org/wiki/Packaging/Guidelines#macros otherwise it looks good spec file is in english and have correct name directories, files and ownership is correct compiling/building ok dependencies ok clean section present please fix 1],2],3]. 1) I am now explicitly setting the CFLAGS in the spec file, which both adds the Fedora optimization flags and also overrides the Makefile's defaults (so the spec file has to include a couple flags specific to clc).
2) Annoyingly, the tarballs were identical in contents other than timestamps on the files. I made sure I have the tarball directly from upstream in SOURCES now.
3) The package is using the macros/variables consistently. I had $RPM_BUILD_ROOT only and no references to %{buildroot}. The link you provided states that I should use one or the other (with no official preference towards either) and that I should not mix usage of $RPM_BUILD_ROOT and %{buildroot} in a single spec file, which I already complied with. I converted to the macro style anyway since it looks nicer IMO, and I used the macro style for %{optflags} as well.
New files:
Spec URL: http://middleditch.us/sean/clc.spec
SRPM URL: http://middleditch.us/sean/clc-0.01-4.fc12.src.rpm
approved New Package CVS Request ======================= Package Name: clc Short Description: Very simplistic MUD client for command line usage Owners: elanthis Branches: F12 cvs done. |