Bug 520368

Summary: [Match BZ34 DB change]:Remove column products.disallownew
Product: [Retired] Red Hat Hardware Certification Program Reporter: XINSUN <xisun>
Component: Hardware CatalogAssignee: XINSUN <xisun>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: low    
Version: 5.3CC: averma, dkl, dmao, rlandry, tfu, ykun, zhuang
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-12-25 05:31:40 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 520358    

Description XINSUN 2009-08-31 07:22:50 UTC
Description of problem:

DB change:     Remove column products.disallownew
Incidence:     (grep disallownew * -r -C4)

     globals.pl-                                # shown to the user.  So we cache all the data
     globals.pl-                                # about them anyway.
     globals.pl-
     globals.pl-    my $mpart = $dotargetmilestone ? ", milestoneurl" : "";
     globals.pl:    SendSQL("select name, description, votesperuser, disallownew$mpart from products ORDER BY name");
     globals.pl-    while (@line = FetchSQLData()) {
     globals.pl-        my ($p, $d, $votesperuser, $dis, $u) = (@line);
     globals.pl-        $::proddesc{$p} = $d;
     globals.pl-        if (!$dis && scalar($::components{$p})) {
     
    Analysis: Above line are in function GetVersionTable() invoked by post.cgi,process.cgi.. It should be modified when bz3.4 push ]

Comment 2 David Lawrence 2009-09-02 16:21:22 UTC
Just to clarify, products.disallownew has been dropped in BZ 3.4, a new column has replaced it called products.isactive which accomplishes the same thing. So 
you need to check for products.isactive = 1 when forming a list of products that the user can enter a bug(cert) against.

Dave