Bug 520866
| Summary: | cluster.ng is very out of date and does not parse logging tags correctly | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Shane Bradley <sbradley> | ||||||||
| Component: | system-config-cluster | Assignee: | Lon Hohberger <lhh> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Cluster QE <mspqa-list> | ||||||||
| Severity: | urgent | Docs Contact: | |||||||||
| Priority: | urgent | ||||||||||
| Version: | 5.5 | CC: | bbrock, ccaulfie, cluster-maint, cward, djuran, fnadge, mgrac, rmccabe, sbradley, syeghiay, tao | ||||||||
| Target Milestone: | rc | Keywords: | ZStream | ||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | system-config-cluster-1.0.57-7 | Doc Type: | Bug Fix | ||||||||
| Doc Text: |
Previously, system-config-cluster failed parse logging tags and related children because the cluster.ng file did not contain those tags. This update adds the tags for the logger parent and its children.
|
Story Points: | --- | ||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2011-01-13 23:58:53 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 629083 | ||||||||||
| Attachments: |
|
||||||||||
~~ Attention Customers and Partners - RHEL 5.5 Beta is now available on RHN ~~ RHEL 5.5 Beta has been released! There should be a fix present in this release that addresses your request. Please test and report back results here, by March 3rd 2010 (2010-03-03) or sooner. Upon successful verification of this request, post your results and update the Verified field in Bugzilla with the appropriate value. If you encounter any issues while testing, please describe them and set this bug into NEED_INFO. If you encounter new defects or have additional patch(es) to request for inclusion, please clone this bug per each request and escalate through your support representative. This is valid, but the patch needs to be reviewed by Chrissie. Looks like there's syslog_facility which is also valid for the logger tag. The <logging> tree looks like this: logging: to_file: yes|no to_syslog: yes|no to_stderr: yes|no debug: on|off timestamp: on|off logfile: <name> fileline: on|off syslog_facility: daemon|local[0..7] logger: ident: <name> debug: on/off tags: enter|leave|trace[1..8] Created attachment 430378 [details]
Updated patch with more options added.
Added the options that was requested in previous comment. It appears previous patch has already been included. This patch was built against:system-config-cluster-1.0.57-3.src.rpm
*** Bug 606826 has been marked as a duplicate of this bug. *** *** Bug 597258 has been marked as a duplicate of this bug. *** Proposed updated schema here: http://people.redhat.com/lhh/cluster-rhel5.rng Created attachment 442277 [details]
Updated patch.
I added some missing things which were since added to 5.6 (but not RHEL 5.5) clustering, including __max_restarts / __restart_expire_time for resources, orainstance/oralistener metadata support, fence_cisco_ucs, and fence_rhev support. I replaced the patch in the package with a new one and rebuilt as 1.0.57-7 All tests of new xml elements and attributes in comment 26 validate with xmllint of system-config-cluster-1.0.57-7 Do any specific attributes need to be tested for the new elements? Any UI changes for any of the new elements/attributes? There are no new UI elements that I am aware of that correspond to the updated schema. That is, the schema may provide things that the UIs do not provide, but not all entries in the schema are supposed to have UI elements corresponding to them. In the cman man-page we give the following example: <logging to_stderr="yes"> <logger ident="CPG" debug="on" to_stderr="yes"> </logger> <logger ident="CMAN" debug="on" to_stderr="yes"> </logger> </logging> The to_stderr attributes of the "logger" tag are not mentinoned in the relaxng file and will cause it to fail validation.
Technical note added. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.
New Contents:
Previously, system-config-cluster failed parse logging tags and related children because the cluster.ng file did not contain those tags. This update adds the tags for the logger parent and its children.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2011-0101.html |
Created attachment 359563 [details] Patch to add the logger tag into cluster.ng Description of problem: system-config-cluster will error on logging tags and its children. For example: <logging to_stderr="yes"> <logger ident="CPG" debug="on" to_stderr="yes"> </logger> <logger ident="CMAN" debug="on" to_stderr="yes"> </logger> </logging> The reason that it error is because its cluster.ng file does not contain those tags. Created a patch to resolve this issue by adding in the tags for logger parent and its children. Version-Release number of selected component (if applicable): system-config-cluster-1.0.55-1.0 How reproducible: Everytime Steps to Reproduce: 1.Add in the tags above inside <cluster> tags in the cluster.conf 2.Open the cluster.conf with scc Actual results: An xml parsing error occurs. Expected results: No error should occur. Additional info: