Bug 521245

Summary: Review Request: constantine-kde-theme - Constantine KDE Theme
Product: [Fedora] Fedora Reporter: Jaroslav Reznik <jreznik>
Component: Package ReviewAssignee: Rex Dieter <rdieter>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, rdieter
Target Milestone: ---Flags: rdieter: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-09-24 20:07:00 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Description Jaroslav Reznik 2009-09-04 13:46:00 UTC
Spec URL: http://rezza.hofyland.cz/fedora/packages/constantine-kde-theme/constantine-kde-theme.spec
SRPM URL: http://rezza.hofyland.cz/fedora/packages/constantine-kde-theme/constantine-kde-theme-11.90.2-1.fc12.src.rpm
Description: This is Constantine KDE Theme Artwork containing KSplash theme and KDM theme.

It's first try, please comment but we need it pre-prepared.

Comment 1 Rex Dieter 2009-09-04 14:38:40 UTC
looks simple enough...

licensing... ok

source...
7d73d3b9e1e00343d624c048b375393f  constantine-kde-theme-11.90.2.tar.bz2

rpmlint:
$ rpmlint *.rpm
constantine-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/ksplash/Themes/Constantine/2048x1536/constantine.png ../../../../../../backgrounds/constantine/default/standard/constantine.png
constantine-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/ksplash/Themes/Constantine/1920x1200/constantine.png ../../../../../../backgrounds/constantine/default/wide/constantine.png
constantine-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/ksplash/Themes/Constantine/2048x1536/logo.png ../../../../../../pixmaps/system-logo-white.png
constantine-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/Constantine/system-logo-white.png ../../../../../pixmaps/system-logo-white.png
constantine-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/Constantine/constantine.png ../../../../../backgrounds/constantine/default/standard/constantine.png
1 packages and 0 specfiles checked; 0 errors, 5 warnings.

confirmed symlinks are satisfied by constantine-backgrounds dep.

functionality: ksplash, kdm works ok (first draft, modulo minor esthetic issues... can be sorted out later).


APPROVED.

Comment 2 Jaroslav Reznik 2009-09-04 14:59:01 UTC
Rex, thanks for quick review.

New Package CVS Request
=======================
Package Name: constantine-kde-theme
Short Description: Constantine KDE Theme 
Owners: jreznik rdieter kkofler ltinkl than 
Branches:
InitialCC:

Comment 3 Kevin Fenzi 2009-09-04 20:15:00 UTC
cvs done.

Comment 4 Rex Dieter 2009-09-24 20:07:00 UTC
built for rawhide.