Bug 521352
| Summary: | Review Request: libvmime07 - A powerful C++ class library for working with MIME/Internet messages | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Robert Scheck <redhat-bugzilla> |
| Component: | Package Review | Assignee: | Andreas Osowski <th0br0> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting, th0br0 |
| Target Milestone: | --- | Flags: | th0br0:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.7.1-1.el4 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-09-16 22:09:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 498194 | ||
|
Description
Robert Scheck
2009-09-05 01:21:56 UTC
Package Review
==============
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines
[x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on:
[x] F10/i386
[x] Rpmlint output:
Source RPM:
[makerpm@hattan libvmime07]$ rpmlint libvmime07-0.7.1-1.fc10.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Binary RPM(s):
[makerpm@hattan libvmime07]$ rpmlint libvmime07-devel-0.7.1-1.fc10.i386.rpm
libvmime07-devel.i386: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
[makerpm@hattan libvmime07]$ rpmlint libvmime07-0.7.1-1.fc10.i386.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[x] Package is not relocatable.
[x] Buildroot is correct
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type: GPLv2+
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
SHA1SUM of package: 30fefbdd31c2fa46976984f18d4d21bf3c2ec20a
[x] Package is not known to require ExcludeArch
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly.
[x] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[-] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package has a %clean section, which contains rm -rf %{buildroot}.
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[x] Package uses nothing in %doc for runtime.
[x] Header files in -devel subpackage, if present.
[x] Static libraries in -devel subpackage, if present.
[x] Package requires pkgconfig, if .pc files are present.
[x] Development .so files in -devel subpackage, if present.
[] Fully versioned dependency in subpackages, if present.
[x] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS ===
[-] Latest version is packaged.
[x] Package does not include license text files separate from upstream.
[-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x] Reviewer should test that the package builds in mock.
Tested on: F10/i386
[] Package should compile and build into binary rpms on all supported
architectures.
Tested on: -
[-] Package functions as described.
[-] Scriptlets must be sane, if used.
[x] The placement of pkgconfig(.pc) files is correct.
[-] File based requires are sane.
Remaining issues:
None
================
*** APPROVED ***
================
Andreas, thank you for the review. New Package CVS Request ======================= Package Name: libvmime07 Short Description: A powerful C++ class library for working with MIME/Internet messages Owners: robert Branches: EL-4 EL-5 F-10 F-11 InitialCC: CVS done. Package: libvmime07-0.7.1-1.fc12 Tag: dist-f12 Status: complete Built by: robert Package: libvmime07-0.7.1-1.fc11 Tag: dist-f11-updates-candidate Status: complete Built by: robert Package: libvmime07-0.7.1-1.fc10 Tag: dist-f10-updates-candidate Status: complete Built by: robert Package: libvmime07-0.7.1-1.el5 Tag: dist-5E-epel-testing-candidate Status: complete Built by: robert Package: libvmime07-0.7.1-1.el4 Tag: dist-4E-epel-testing-candidate Status: complete Built by: robert libvmime07-0.7.1-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/libvmime07-0.7.1-1.fc10 libvmime07-0.7.1-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/libvmime07-0.7.1-1.fc11 libvmime07-0.7.1-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/libvmime07-0.7.1-1.el5 libvmime07-0.7.1-1.el4 has been submitted as an update for Fedora EPEL 4. http://admin.fedoraproject.org/updates/libvmime07-0.7.1-1.el4 libvmime07-0.7.1-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. libvmime07-0.7.1-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. libvmime07-0.7.1-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. libvmime07-0.7.1-1.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report. |