Bug 521430
| Summary: | Review Request: etckeeper - Store /etc in git, mercurial, bzr or darcs | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Bernie Innocenti <bernie+fedora> | ||||
| Component: | Package Review | Assignee: | Terje Røsten <terje.rosten> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora-package-review, herrold, notting, terje.rosten, thomas.moschny | ||||
| Target Milestone: | --- | Flags: | terje.rosten:
fedora-review+
kevin: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-09-30 03:58:32 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Bernie Innocenti
2009-09-05 20:28:30 UTC
Nice package, I did some tweaks to the spec file: - Package is noarch - Rpmlint clean (as it gets) - Random cleanup - Ship cache dir in package - bzr subpackage - Add bzr to buildreq - Terje Created attachment 360325 [details] Improved etckeeper spec. The spec file in comment #2. All your changes seem good to me, thanks. Would you like to approve the review? The review has not started yet, for starters the package don't build in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1674016 http://koji.fedoraproject.org/koji/getfile?taskID=1674016&name=build.log Fix that (hint: python-devel) and I will do a formal review. Ok this one works: http://codewiz.org/pub/fedora/specs/etckeeper.spec http://codewiz.org/pub/fedora/source/etckeeper-0.40-3.fc12.src.rpm - rpmlint
etckeeper.src:76: E: hardcoded-library-path in %{_prefix}/lib/yum-plugins/%{name}.*
etckeeper.noarch: W: only-non-binary-in-usr-lib
etckeeper.noarch: W: non-conffile-in-etc /etc/etckeeper/post-install.d/README
etckeeper.noarch: W: non-conffile-in-etc /etc/etckeeper/init.d/README
etckeeper.noarch: W: non-conffile-in-etc /etc/etckeeper/update-ignore.d/README
etckeeper.noarch: W: non-conffile-in-etc /etc/etckeeper/uninit.d/README
etckeeper.noarch: W: non-conffile-in-etc /etc/etckeeper/commit.d/README
etckeeper.noarch: W: non-conffile-in-etc /etc/etckeeper/pre-install.d/README
etckeeper.noarch: W: non-conffile-in-etc /etc/etckeeper/pre-commit.d/README
etckeeper.noarch: W: non-conffile-in-etc /etc/etckeeper/unclean.d/README
3 packages and 0 specfiles checked; 1 errors, 9 warnings.
All these errors and warnings is harmless. ok.
- naming. ok.
- spec file name. ok.
- legible and American English. ok.
! license. GPL file has GPLv2, while debian/copyright has GPLv2+
no files has license information, could you ping upstream about this?
- guidelines. ok. remove comments in spec file?
- source tarball:
d41439dd78d1f85ad77aafdbeed4d460 etckeeper_0.40.tar.gz
d41439dd78d1f85ad77aafdbeed4d460 etckeeper_0.40.tar.gz.1 ok.
- build and runs fine.
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1675401 ok.
! own all dirs.
+ add %dir /etc/etckeeper, it's not include.
+ add /etc/bash_completion.d too (a bit strange, seems to be normal though)
+ /usr/lib/yum-plugins and /etc/yum/pluginconf.d: this is possible yum dep,
however I am tempted to relax that.
- defattr. ok.
- file listing. ok.
- clean, macros. ok.
- subpackage. ok.
- install, utf-8. ok.
Optional:
etckeeper.8 has:
SEE ALSO
/usr/share/doc/etckeeper/README.gz
could change that by sed/perl to %{_docdir}/%{name}-%{version}/README
Any progress here? > ! license. GPL file has GPLv2, while debian/copyright has GPLv2+ > no files has license information, could you ping upstream about this? README says "etckeeper is licensed under version 2 or greater of the GNU GPL" > ! own all dirs. > + add %dir /etc/etckeeper, it's not include. > + add /etc/bash_completion.d too (a bit strange, seems to be normal though) > + /usr/lib/yum-plugins and /etc/yum/pluginconf.d: this is possible yum dep, > however I am tempted to relax that. Fixed. I updated the package to 0.41: http://codewiz.org/pub/fedora/specs/etckeeper.spec http://codewiz.org/pub/fedora/source/etckeeper-0.41-1.fc12.src.rpm Thanks, package seems fine now. I have sent an email upstream about the license. You can import the package with GPLv2+ for now, package is APPROVED New Package CVS Request ======================= Package Name: etckeeper Short Description: Store /etc in git, mercurial, bzr or darcs Owners: bernie Branches: F-11 InitialCC: cvs done with F-12 branch added. Imported and built for devel, F12 and F11. Thanks. I can't find the package in F11 updates, can you please push it for F11? (In reply to comment #13) > I can't find the package in F11 updates, can you please push it for F11? Oops, forgot to push it. Please, test the package and give it your +1 if it seems to work. https://admin.fedoraproject.org/updates/etckeeper-0.41-1.fc11?_csrf_token=cd42782cec0223bdd513a51ab8163fbf45b3e9de See bug 570623. Package Change Request ====================== Package Name: etckeeper New Branches: el5 el6 Owners: thm Git done (by process-git-requests). |