Bug 521552

Summary:	Malformed string in pulseaudio
Product:	[Fedora] Fedora	Reporter:	Miloš Komarčević <kmilos>
Component:	pulseaudio	Assignee:	Lennart Poettering <lpoetter>
Status:	CLOSED UPSTREAM	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	lkundrak, lpoetter, wtogami
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-09-07 21:35:30 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Miloš Komarčević 2009-09-06 22:27:06 UTC

gettext tools report the following warning:

internationalized messages should not contain the `\r' escape sequence

The string in question is:

#: ../src/utils/pacat.c:577
#, c-format
msgid "Time: %0.3f sec; Latency: %0.0f usec.  \r"

Comment 1 Lennart Poettering 2009-09-07 14:26:01 UTC

But the \r is actually intended to be there (to move the cursor back to the beginning of the line). I really don't see what the point would be to drop that.

Comment 2 Miloš Komarčević 2009-09-07 16:37:04 UTC

By all means leave that control sequence in the code if that is the intended behaviour, but you could move it out from the translatable string, i.e. break those up. That way you can guarantee the intended behaviour and not risk some translator removing control sequences because gettext complains - separating real language content from functionality, makes sense, no?

Comment 3 Lennart Poettering 2009-09-07 21:35:30 UTC

Ok. Convinced.

Fixed upstream. Will hit rawhide shortly.