Bug 522326

Summary:	Review Request: lohit-gujarati-fonts - Open Type Font for Gujarati Language
Product:	[Fedora] Fedora	Reporter:	Pravin Satpute <psatpute>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-package-review, fonts-bugs, i18n-bugs, notting, petersen
Target Milestone:	---	Flags:	panemade: fedora-review+ petersen: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-09-11 11:57:36 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Pravin Satpute 2009-09-10 05:32:30 UTC

SPEC URL : http://pravins.fedorapeople.org/SPECS/lohit-gujarati-fonts.spec

SRPM URL :
http://pravins.fedorapeople.org/SRPMS/lohit-gujarati-fonts-2.4.3-1.fc11.src.rpm

This package contains open type fonts for gujarati language, gujarati script.

Please note that this were part of lohit-fonts package previously, now lohit
upstream releasing it as a separate tarball.

Comment 1 Parag AN(पराग) 2009-09-10 10:52:25 UTC

Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1667721
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
bd640f2783385686d0c5978ac2b9747d399a819b  lohit-gujarati-2.4.3.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ fonts scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

APPROVED.

Comment 2 Pravin Satpute 2009-09-11 04:15:24 UTC

New Package CVS Request
=======================
Package Name: lohit-gujarati-fonts
Short Description: Free Gujarati Open Type Font
Owners: pravins
Branches:
InitialCC: fonts-sig

Comment 3 Jens Petersen 2009-09-11 08:13:38 UTC

added

Comment 4 Pravin Satpute 2009-09-11 11:36:44 UTC

completed build
Thanks Parag and Jens