Bug 522356
| Summary: | Review Request: lohit-tamil-fonts - Open Type Font for Tamil Language | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Pravin Satpute <psatpute> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, fonts-bugs, i18n-bugs, notting, petersen |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
petersen: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-09-11 11:57:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Pravin Satpute
2009-09-10 06:43:43 UTC
Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1667834 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 5eba3c34ae0798bf65e271fe3da28bc05c9c49aa lohit-tamil-2.4.3.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + fonts scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application APPROVED. New Package CVS Request ======================= Package Name: lohit-tamil-fonts Short Description: Free Tamil Open Type Font Owners: pravins Branches: InitialCC: fonts-sig BTW it'd really be a little cleaner if there was a real makefile in the package, even if it only contains two lines to call generate.pe make is a standard interface people are used to and expect, and it will also give you parallelism when you have multiple files to process cvs admin done Nicolas, surely in next release of upstream i will do that, for all lohit language fonts Thanks. Lohit distribution practices were a lot worse for years, so it's not an urgent thing to fix. I agree there's little harm in waiting to do it for next release Another cleanup would be to host the lohit release tarballs in the fedorahosted project, a fedorapeople space is not very professional on our part I have some lohit fixes in queue, once those will complete i will update other suggested things as well :) completed build Thanks Parag and Jens |