Bug 522394

Summary:	Review Request: maven-plugin-cobertura - Plugin providing the features of Cobertura within Maven
Product:	[Fedora] Fedora	Reporter:	Alexander Kurtakov <akurtako>
Component:	Package Review	Assignee:	Andrew Overholt <overholt>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, overholt
Target Milestone:	---	Flags:	overholt: fedora-review+ dennis: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-09-11 04:56:31 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Alexander Kurtakov 2009-09-10 09:48:01 UTC

Spec URL: http://akurtakov.fedorapeople.org/maven-plugin-cobertura.spec
SRPM URL: http://akurtakov.fedorapeople.org/maven-plugin-cobertura-2.3-2.fc11.src.rpm
Description: This plugin provides the features of Cobertura within the Maven 2 environment.
The report generated by this plugin is the result of executing the Cobertura
tool against your compiled classes to help you determine how well the unit
testing efforts have been, and can then be used to identify which parts
of your Java program are lacking test coverage.

Comment 1 Andrew Overholt 2009-09-10 14:22:43 UTC

X please add a comment for the patch (the patch itself seems fine)
X license seems to be ASL 2.0 for the plugin but parts contained (some .js files) are GPL v2 and GPL v2+.  Please reflect this in the license field.
X please add your real name to the changelog

- naming fine
- builds fine
- %files fine
- macros fine
- Requires good
- sources match upstream
- rpmlint fine:

$ rpmlint /home/overholt/rpmbuild/SRPMS/maven-plugin-cobertura-2.3-2.fc11.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint /home/overholt/rpmbuild/RPMS/noarch/maven-plugin-cobertura-2.3-2.fc11.noarch.rpm
maven-plugin-cobertura.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint /home/overholt/rpmbuild/RPMS/noarch/maven-plugin-cobertura-javadoc-2.3-2.fc11.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 2 Alexander Kurtakov 2009-09-10 14:55:36 UTC

(In reply to comment #1)
> X please add a comment for the patch (the patch itself seems fine)
Fixed.
> X license seems to be ASL 2.0 for the plugin but parts contained (some .js
> files) are GPL v2 and GPL v2+.  Please reflect this in the license field.
Fixed.
> X please add your real name to the changelog
Fixed.
> 

New sources:
Spec URL: http://akurtakov.fedorapeople.org/maven-plugin-cobertura.spec
SRPM URL:
http://akurtakov.fedorapeople.org/maven-plugin-cobertura-2.3-3.fc11.src.rpm

Comment 3 Andrew Overholt 2009-09-10 14:58:37 UTC

Thanks, approved.

Comment 4 Alexander Kurtakov 2009-09-10 17:22:33 UTC

New Package CVS Request
=======================
Package Name: maven-plugin-cobertura 
Short Description: Plugin providing the features of Cobertura within Maven
Owners: akurtakov
Branches: 
InitialCC:

Comment 5 Dennis Gilmore 2009-09-10 18:33:26 UTC

CVS Done

Comment 6 Alexander Kurtakov 2009-09-11 04:56:31 UTC

Build in rawhide.