Bug 522732
Summary: | Review Request: perl-Text-Diff-Parser - Parse patch files containing unified and standard diffs | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Emmanuel Seyman <emmanuel> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 0.1001-1.fc11 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-10-01 00:03:02 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Emmanuel Seyman
2009-09-11 08:43:43 UTC
Upstream has released a new version, fixing a bug I reported. Spec URL: http://people.parinux.org/~seyman/fedora/perl-Text-Diff-Parser/perl-Text-Diff-Parser.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Text-Diff-Parser/perl-Text-Diff-Parser-0.1001-1.fc11.src.rpm Builds fine and rpmlint is silent. Note that a test is skipped because of a missing build dependency (Pod::Coverage). POD coverage is generally a maintainer check anyway, so I don't think it's a big deal, but you run the POD checks so I figured you might want to run the coverage checks too. * source files match upstream. sha256sum: 3d69fa8eb97405a6bd398d0d9305a0aaa0f83cfa176a8660ab58674282cc0266 Text-Diff-Parser-0.1001.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: perl(Text::Diff::Parser) = 0.1001 perl(Text::Diff::Parser::Change) perl-Text-Diff-Parser = 0.1001-1.fc12 = perl >= 0:5.00404 perl(:MODULE_COMPAT_5.10.0) perl(Carp) perl(IO::File) perl(strict) perl(vars) perl(warnings) * %check is present and all tests pass: All tests successful. Files=7, Tests=58, 0 wallclock secs ( 0.05 usr 0.02 sys + 0.36 cusr 0.06 csys = 0.49 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED The package review process needs reviewers! If you haven't done any package reviews recently, please consider doing one. (In reply to comment #2) > > APPROVED Thanks, Jason. Requesting CVS. New Package CVS Request ======================= Package Name: perl-Text-Diff-Parser Short Description: Parse patch files containing unified and standard diffs Owners: eseyman Branches: F-10 F-11 F-12 InitialCC: perl-sig cvs done. perl-Text-Diff-Parser-0.1001-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-Text-Diff-Parser-0.1001-1.fc10 perl-Text-Diff-Parser-0.1001-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Text-Diff-Parser-0.1001-1.fc11 perl-Text-Diff-Parser-0.1001-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Text-Diff-Parser'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-9930 perl-Text-Diff-Parser-0.1001-1.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Text-Diff-Parser'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-9956 perl-Text-Diff-Parser-0.1001-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. perl-Text-Diff-Parser-0.1001-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |