Bug 522743
| Summary: | Initscript: Missing required actions (condrestart, try-restart and force-reload) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Šplíchal <psplicha> |
| Component: | sysstat | Assignee: | Ivana Varekova <varekova> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | ohudlick, varekova |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-09-14 14:05:47 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 521669 | ||
Calling an unsupported action should return 2: :: [ FAIL ] :: Running 'service sysstat' (Expected 2, got 1) :: [ FAIL ] :: Running 'service sysstat nothing' (Expected 2, got 1) https://fedoraproject.org/wiki/Packaging/SysVInitScript#Exit_Codes_for_non-Status_Actions Just an additional remark: Using the exitCodeIndicator to find out
the exit status of calling /usr/lib/sa/sa1 seems to be needless and
mentioned comment irrelevant as the sa1 is now called under root:
# Try to guess if sadc was successfully launched. The
# difficulty here is that the exit code is lost when the above
# command is run via "su foo -c ..."
Fixed in sysstat-9.0.3-3. ad comment #2: this is part of upstream setting, I will discuss the code with upstream later. |
Description of problem: The sysstat's initscript is missing the following actions required by Fedora SysV Initscripts Guidelines: * condrestart (and try-restart) * force-reload Although the sysstat does not work as a regular service, it would be nice to have these actions covered to provide consistent interface across all services. Version-Release number of selected component (if applicable): sysstat-9.0.3-1.fc12.i586 Additional info: https://fedoraproject.org/wiki/Packaging/SysVInitScript#Required_Actions