Bug 523355
Summary: | Review Request: kio_gopher - Gopher KIO slave for Konqueror | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Kevin Kofler <kevin> |
Component: | Package Review | Assignee: | Jaroslav Reznik <jreznik> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, jreznik, notting |
Target Milestone: | --- | Flags: | jreznik:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-09-17 23:58:34 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Kevin Kofler
2009-09-15 04:08:17 UTC
Well, quick review as this is simple package. rpmlint OK build (local OK) (in Koji OK) (archs OK) name OK URL & sources OK sources MD5 OK license OK (GPLv2+) buildroot OK works OK I'm not sure about versioning - in upstream tarball kde-4.3.1 is in version tag, in some other own packages we omit it. We should be consistent in versioning. I can drop the kde4.3.1 tag from Release if you prefer, I'm not particularly attached to it (i.e. I'm fine with removing it). (But the guidelines do allow non-numeric versioning tags after the disttag.) (In reply to comment #2) > I can drop the kde4.3.1 tag from Release if you prefer, I'm not particularly > attached to it (i.e. I'm fine with removing it). Well, please remove it. Spec URL: http://repo.calcforge.org/f12/kio_gopher.spec SRPM URL: http://repo.calcforge.org/f12/kio_gopher-0.1.3-2.fc10.src.rpm * Tue Sep 15 2009 Kevin Kofler <Kevin.org> - 0.1.3-2 - drop postfix tag from Release Ugh, the date is wrong in the changelog entry... I guess I'll fix that when importing the package. ;-) Reuploaded with the correct changelog date (Wed Sep 16 2009). ;-) APPROVED You're supposed to set fedora-review+, not fedora-cvs+. (In reply to comment #8) > You're supposed to set fedora-review+, not fedora-cvs+. Ah, thanks, my mistake... I was setting fedora-cvs+ on another review and you, sometimes you do thinks automaticaly ;-) New Package CVS Request ======================= Package Name: kio_gopher Short Description: Gopher KIO slave for Konqueror Owners: kkofler jreznik rdieter ltinkl than svahl Branches: F-10 F-11 InitialCC: tuxbrewr cvs done. Imported, built. |