Bug 523391

Summary: initscript collected problems LSB-compilant watchdog
Product: [Fedora] Fedora Reporter: Jan Ščotka <jscotka>
Component: watchdogAssignee: Richard W.M. Jones <rjones>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: dkovalsk, rjones
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 584701 (view as bug list) Environment:
Last Closed: 2011-01-17 14:01:15 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 521669, 584701    

Description Jan Ščotka 2009-09-15 10:16:24 UTC
There are some problems with LSB-compilants of initscript against
https://fedoraproject.org/wiki/Packaging/SysVInitScript definition.

service: watchdog

I've created some test and there is output of run (PASS menas that it started correctly, FAIL, that there is some problem with returncode, explanaition in brackets):

:: [   LOG    ] :: >>>>>>>>> service start
:: [   PASS   ] ::  Service must start without problem
:: [   PASS   ] ::  Then Status command 
:: [   FAIL   ] ::  Already started service  (Expected 0, got 1)
:: [   PASS   ] ::  Again status command 
:: [   LOG    ] :: >>>>>>>>> service restart
:: [   PASS   ] ::  Restarting of service
:: [   PASS   ] ::  Status command 
:: [   LOG    ] :: >>>>>>>>> service stop
:: [   PASS   ] ::  Stopping service 
:: [   FAIL   ] ::  Status of stopped service  (Expected 3, got 0)
:: [   PASS   ] ::  Stopping service again 
:: [   FAIL   ] ::  Status of stopped service  (Expected 3, got 0)
:: [   LOG    ] :: >>>>>>>>> pid file
:: [   FAIL   ] :: File /var/run/watchdog.pid should exist 
:: [   PASS   ] :: Running 'echo 666666 > /var/run/watchdog.pid'
:: [   FAIL   ] ::  Existing pid file, but service not started  (Expected 1, got 0)
:: [   LOG    ] :: >>>>>>>>> lock file
:: [   FAIL   ] :: File /var/lock/subsys/watchdog should exist 
:: [   PASS   ] :: Running 'touch /var/lock/subsys/watchdog'
:: [   FAIL   ] ::  Existing lock file, but service not started  (Expected 2, got 0)
:: [   LOG    ] :: >>>>>>>>> insufficient rights
:: [   FAIL   ] ::  Starting service for restarting under nonpriv user  (Expected 0, got 1)
:: [   FAIL   ] :: Insufficient rights, restarting resrvice under nonprivileged user must fail (Expected 4, got 0)
:: [   LOG    ] :: >>>>>>>>> operations
:: [   FAIL   ] ::  Service have to implement start function  (Expected 0, got 1)
:: [   PASS   ] ::  Service have to implement restart function 
:: [   PASS   ] ::  Service have to implement status function 
:: [   FAIL   ] ::  Service have to implement usage function  (Expected 0, got 1)
:: [   PASS   ] ::  Service have to implement condrestart function 
:: [   FAIL   ] ::  Service have to implement try-restart function  (Expected 0, got 1)
:: [   PASS   ] ::  Service have to implement reload function 
:: [   FAIL   ] ::  Service have to implement force-reload function  (Expected 0, got 1)
:: [   LOG    ] :: >>>>>>>>> nonexist operations
:: [   FAIL   ] ::  Testing proper return code when nonexisting function (Expected 2, got 1)
:: [   LOG    ] :: >>>>>>>>> invalid arguments
:: [   FAIL   ] ::  When no arguments added to service, it must fail with proper return code  (Expected 2, got 1)


There are some problems:
* second starting of watchdog, must retun 0 code, no 1, (already runned, so no action, but returncode 0)
* there is expected that return code status command when service is stopped will be 3
* is expected that pid file exist and is used by program and is returned proper return code when status find service not running but pid file exists
* same as previous problem but for lock file
*  when watchdog started under unprevileged users it must fails with return code 4
* there should be implemented or returned proper code (3 - not implemneted) usage, try-restart, force-reload
* when there is used bad or none argument it must return code 2

Comment 1 Bug Zapper 2009-11-16 12:25:08 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 12 development cycle.
Changing version to '12'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 3 Bug Zapper 2010-11-04 10:01:39 UTC
This message is a reminder that Fedora 12 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 12.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '12'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 12's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 12 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 4 Richard W.M. Jones 2010-11-04 11:11:04 UTC
Update to Rawhide.

Comment 5 Richard W.M. Jones 2011-01-17 14:01:15 UTC
I have done some fixes to the init script:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2725958