Bug 523435

Summary: bind initscript [LSB|FedoraGuidelines] compliance
Product: [Fedora] Fedora Reporter: Matěj Šusta <msusta>
Component: bindAssignee: Adam Tkac <atkac>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: 12CC: atkac, dkovalsk, mwest, ohudlick, ovasik, pwouters, ykopkova
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: bind-9.7.0-2.fc14 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-12-05 06:24:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 521669    

Description Matěj Šusta 2009-09-15 13:54:44 UTC
Description of problem:
Some people don't want to call this bug "lsb compliance" or whatever, so here is bug which addresses bind initscript problems.

Version-Release number of selected component (if applicable):
bind-9.6.1-4.P1.fc11.i586

##########

[root@hostel-280 ~]# service named
Usage: /etc/init.d/named {start|stop|status|restart|try-restart|reload|force-reload}
[root@hostel-280 ~]# echo $?
3

WRONG - invalid or excess arg. should return 2

##########

[root@hostel-280 ~]# service named status
rndc: connect failed: 127.0.0.1#953: connection refused
named is stopped
[root@hostel-280 ~]# echo $?                           
3
[root@hostel-280 ~]# service named start               
Starting named:                                            [  OK  ]
[root@hostel-280 ~]# echo $?                                       
0
[root@hostel-280 ~]# service named status
version: 9.6.1-P1-RedHat-9.6.1-4.P1.fc11
CPUs found: 2
worker threads: 2
number of zones: 15
debug level: 0
xfers running: 0
xfers deferred: 0
soa queries in progress: 0
query logging is OFF
recursive clients: 0/0/1000
tcp clients: 0/100
server is up and running
named (pid  2347) is running...
[root@hostel-280 ~]# echo $?
0
[root@hostel-280 ~]# service named start
Starting named: named: already running                     [FAILED]
[root@hostel-280 ~]# echo $?
1

WRONG - attempt to start running service should at least return 0,
        no guide on what to output in console, other services
        defaults to OK

##########

[root@hostel-280 ~]# touch /var/lock/subsys/named
[root@hostel-280 ~]# service named status
rndc: connect failed: 127.0.0.1#953: connection refused
named dead but subsys locked
[root@hostel-280 ~]# echo $?
2
[root@hostel-280 ~]# service named condrestart
condrestart option is obsolete. Use try-restart instead
Stopping named:                                            [  OK  ]
Starting named:                                            [  OK  ]
[root@hostel-280 ~]# echo $?
0

WRONG - https://fedoraproject.org/wiki/Packaging/SysVInitScript#condrestart_and_try-restart

[root@hostel-280 ~]# service named usage
Usage: /etc/init.d/named {start|stop|status|restart|try-restart|reload|force-reload}
[root@hostel-280 ~]# echo $?
3

WRONG - usage have to be implemented, exitcode should be 0

Comment 2 Yulia Kopkova 2009-10-07 14:45:04 UTC
One more issue that needs to be fixed:

Init script should return code "4" if restarting service under
nonprivileged user:
# su testuserqa -c "service $SERVICE restart"; echo $?
restart: unrecognized service
1
now: 6 
expected: 4

Comment 3 Yulia Kopkova 2009-10-08 10:58:42 UTC
Sorry, please ignore previous comment #2.

Init script should return code "4" if restarting service under
nonprivileged user:
# su testuserqa -c "service named restart"; echo $?
chown: changing ownership of `/var/named': Operation not permitted
Stopping named:                                            [  OK  ]
Cannot find configuration file. You could create it by system-config-bind
6
now: 6
expected: 4

Comment 4 Bug Zapper 2009-11-16 12:25:48 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 12 development cycle.
Changing version to '12'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 6 Adam Tkac 2010-01-27 17:44:13 UTC
Fixed in bind-9.7.0-0.12.rc1.fc13.

Comment 8 Yulia Kopkova 2010-01-29 20:44:19 UTC
Sorry, Adam. I did not noticed a mistake in bug report :(

On nonexist action initscript should return code "2":
# service named nonexist ; echo $?
Usage: /etc/init.d/named {start|stop|status|restart|try-restart|reload|force-reload}
3
now: 3
expected: 2

Can you, please, also fix when get a chance?

Comment 9 Adam Tkac 2010-03-01 13:30:29 UTC
(In reply to comment #8)
> Sorry, Adam. I did not noticed a mistake in bug report :(
> 
> On nonexist action initscript should return code "2":
> # service named nonexist ; echo $?
> Usage: /etc/init.d/named
> {start|stop|status|restart|try-restart|reload|force-reload}
> 3
> now: 3
> expected: 2
> 
> Can you, please, also fix when get a chance?    

Fixed in bind-9.7.0-2.fc14.

Comment 11 Bug Zapper 2010-11-04 10:01:25 UTC
This message is a reminder that Fedora 12 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 12.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '12'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 12's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 12 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 12 Bug Zapper 2010-12-05 06:24:26 UTC
Fedora 12 changed to end-of-life (EOL) status on 2010-12-02. Fedora 12 is 
no longer maintained, which means that it will not receive any further 
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of 
Fedora please feel free to reopen this bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.