Bug 523789
Summary: | Review Request: python-mwclient - Mwclient is a client to the MediaWiki API | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Steven M. Parrish <smparrish> |
Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | awilliam, fedora-package-review, kdas, kevin, notting, rdieter, thinklinux.ssh |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | Flags: | rdieter:
fedora-review+
gwync: fedora-cvs+ |
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 0.6.3-3.el5 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-10-28 13:19:31 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 520954 |
Description
Steven M. Parrish
2009-09-16 16:48:06 UTC
srpm here: http://tuxbrewr.fedorapeople.org/python-mwclient/python-mwclient-0.6.3-1.fc11.src.rpm -- Steven M. Parrish - KDE Triage Master - PackageKit Triager Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers Instead of %define, %global should be used in the spec. The upstream tarball seems to bundle python-simplejson, which you install in %install. This is wrong. There is also a Requires: on python-simplejson, so something is wrong. Also copying the c source of _speedups.so is just wrong. Please remove the NotReady from the Whiteboard if these issues are resolved. If you have any questions, please ask. Fixed. New spec and SRPM can be found at the original links You are supposed to bump the revision Looks very simple packaging-wise, not sure how (best) to test functionality though (or maybe doing so against kdeedu/parley can work). I see only 2 problems 1. MUST: include README.txt, it includes licensing text 2. MUST: omit simplejson from packaging address those, and looks like we have a winner. In addition, seems to me that we can use noarch/python_sitelib here instead of making it arch'd + python_sitearch spec/srpm with suggested fixes, tested to work with kdeedu/parley, http://rdieter.fedorapeople.org/rpms/python-mwclient/ Rex, have incorporated your changes in my spec, builds fine. ready to go -- Steven M. Parrish - KDE Triage Master - PackageKit Triager Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers ok then. APPROVED. New Package CVS Request ======================= Package Name: python-mwclient Short Description: Mwclient is a client to the MediaWiki API Owners: tuxbrewr Branches: F10, F11 InitialCC: rdieter CVS done. python-mwclient-0.6.3-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/python-mwclient-0.6.3-3.fc10 python-mwclient-0.6.3-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/python-mwclient-0.6.3-3.fc11 python-mwclient-0.6.3-3.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-mwclient'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-9804 python-mwclient-0.6.3-3.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-mwclient'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-9834 python-mwclient-0.6.3-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. python-mwclient-0.6.3-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. Hi Steven, I am using mwclient on Fedora infrastructure. Will it be possible to have it in epel/rhel repo too? Rakesh has the rpms done http://rakesh.fedorapeople.org/misc/python-mwclient-0.6.3-3.el5.noarch.rpm http://rakesh.fedorapeople.org/misc/python-mwclient-0.6.3-3.el5.src.rpm Thanks. Sure I can do that. I'll request the CVS changes now. Package Change Request ====================== Package Name: python-mwclient New Branches: EL-4 EL-5 Owners: tuxbrewr cvs done. Hello Steven .. may you import this in EL ASAP, it is need for some fedora infra work. Thanks, python-mwclient-0.6.3-3.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/python-mwclient-0.6.3-3.el5 python-mwclient-0.6.3-3.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. Thanks a lot. :) Package Change Request ====================== Package Name: python-mwclient New Branches: epel7 Owners: tuxbrewr rdieter adamwill InitialCC: I've been maintaining this package lately (using provenpackager powers) as my python-wikitcms package uses it. I just realized it doesn't have an epel7 branch, but I've pushed python-wikitcms to epel7, so now we have a broken dep in epel7 :( So requesting an epel7 branch of python-mwclient so I can build it there and fix the wikitcms dep. Git done (by process-git-requests). |