Bug 524016
Summary: | Init script needs a few fixes for LBS compliance (and some cleanup, too) | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Radek Bíba <rbiba> | ||||||||
Component: | mailman | Assignee: | Daniel Novotny <dnovotny> | ||||||||
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
Severity: | medium | Docs Contact: | |||||||||
Priority: | low | ||||||||||
Version: | rawhide | CC: | dnovotny | ||||||||
Target Milestone: | --- | ||||||||||
Target Release: | --- | ||||||||||
Hardware: | All | ||||||||||
OS: | Linux | ||||||||||
Whiteboard: | |||||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||||
Doc Text: | Story Points: | --- | |||||||||
Clone Of: | Environment: | ||||||||||
Last Closed: | 2009-10-07 10:53:00 UTC | Type: | --- | ||||||||
Regression: | --- | Mount Type: | --- | ||||||||
Documentation: | --- | CRM: | |||||||||
Verified Versions: | Category: | --- | |||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||
Embargoed: | |||||||||||
Bug Depends On: | |||||||||||
Bug Blocks: | 521669 | ||||||||||
Attachments: |
|
Description
Radek Bíba
2009-09-17 15:33:33 UTC
Created attachment 361918 [details]
a proposed patch to address those issues
Thanks, the patch isn't perfect, though. * `service mailman stop` when it's already stopped now prints: Shutting down mailman: No child with pid: 24270 [Errno 3] No such process Stale pid file removed. cat: /var/lock/mailman/master-qrunner: No such file or directory ] * `try-restart' wasn't added among options in the usage message. thanks, try-restar fix is straightforward, I will analyze the pidfile thing Created attachment 363654 [details]
a new version of the patch
try-restart fixed, stopping when stopped fixed
Unfortunately this version broke `status': # service mailman start Starting mailman: [ OK ] # echo $? 0 # service mailman status mailman dead but subsys locked # /usr/lib64/mailman/bin/mailmanctl status mailman (pid 7535) is running... Note that while the lock file is named mailman, the process isn't. Umm, it was already broken in the previous patch, but I didn't get that far when verifying it. Created attachment 363839 [details]
3rd version of the patch
OK, let's handle "status" as before, but with a special case when the lock file exists
Works great. Thanks! fixed in rawhide: mailman-2.1.12-10.fc13 |