Bug 524022
Summary: | qemu's pci_add monitor command should not exit() if the NIC model is not valid | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Vladimir Benes <vbenes> | ||||
Component: | qemu | Assignee: | Glauber Costa <gcosta> | ||||
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | high | Docs Contact: | |||||
Priority: | high | ||||||
Version: | rawhide | CC: | berrange, crobinso, dwmw2, gcosta, hbrock, itamar, jaswinder, jforbes, markmc, quintela, virt-maint | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2009-09-28 16:46:21 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 498969 | ||||||
Attachments: |
|
Description
Vladimir Benes
2009-09-17 16:05:34 UTC
Created attachment 361520 [details]
virt-manager.log
This looks like two issues with qemu: 1) When not passed a model and you do pci_add/pci_del/pci_add with no model= parameter, it seems to get the parameters confused 2) It exits when you pass an invalid model= via pci_add rather than just printing an error This is a trivial use-after-free bug. I've just sent a patch upstream Patch is here: http://lists.gnu.org/archive/html/qemu-devel/2009-09/msg01196.html Still need to fix (2), though Patch applied in rawhide now, thanks * Wed Sep 23 2009 Mark McLoughlin <markmc> - 2:0.10.92-5 - Fix issue causing NIC hotplug confusion when no model is specified (#524022) Leaving it open to fix the other issue Should be fixed in rawhide now thanks to a cherry-pick from Markus's series here: http://lists.gnu.org/archive/html/qemu-devel/2009-09/threads.html#01585 * Mon Sep 28 2009 Mark McLoughlin <markmc> - 2:0.11.0-2 - Fix pci hotplug to not exit if supplied an invalid NIC model (#524022) |