Bug 52462
Summary: | tifftopnm ignores photometric interpretation | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Retired] Red Hat Public Beta | Reporter: | Jay Berkenbilt <ejb> | ||||||||
Component: | netpbm | Assignee: | Phil Knirsch <pknirsch> | ||||||||
Status: | CLOSED RAWHIDE | QA Contact: | Brian Brock <bbrock> | ||||||||
Severity: | medium | Docs Contact: | |||||||||
Priority: | medium | ||||||||||
Version: | roswell | CC: | ejb, rvokal | ||||||||
Target Milestone: | --- | ||||||||||
Target Release: | --- | ||||||||||
Hardware: | i386 | ||||||||||
OS: | Linux | ||||||||||
Whiteboard: | |||||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||||
Doc Text: | Story Points: | --- | |||||||||
Clone Of: | Environment: | ||||||||||
Last Closed: | 2001-09-03 13:08:39 UTC | Type: | --- | ||||||||
Regression: | --- | Mount Type: | --- | ||||||||
Documentation: | --- | CRM: | |||||||||
Verified Versions: | Category: | --- | |||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||
Embargoed: | |||||||||||
Attachments: |
|
Description
Jay Berkenbilt
2001-08-23 22:07:02 UTC
Created attachment 29294 [details]
tiff file with min-is-white photometric interpretation
Created attachment 29295 [details]
tiff file with min-is-black photometric interpretation
Created attachment 29296 [details]
patch to fix this problem
I was right. It was simple. I've attached the patch as a file, but I'm including it here as well. I quick glance through the code will indicate that the line of code I deleted wasn't doing anything. Usually when I find something like this, I report it to the "upstream" maintainers as well, but in this case, I don't know what to do because so many patches are applied. My patch is relative to RedHat's version; i.e., after rpm -bp netpbm.spec. --- pnm/tifftopnm.c.qdist Thu Aug 23 18:29:32 2001 +++ pnm/tifftopnm.c Thu Aug 23 18:40:07 2001 @@ -501,8 +501,7 @@ case PHOTOMETRIC_MINISWHITE: for ( col = 0; col < cols; ++col ) { - sample = maxval - sample; - PNM_ASSIGN1( xelrow[col], samplebuf[col] ); + PNM_ASSIGN1( xelrow[col], maxval - samplebuf[col] ); alpharow[col] = 0; } break; Fixed in the latest version, available via rawhide soon. Version: netpbm-9.20-1 Read ya, Phil |