Bug 524822

Summary: remove_invalid_bug_references sanitycheck is failing
Product: [Community] Bugzilla Reporter: Noura El hawary <nelhawar>
Component: Bugzilla GeneralAssignee: Noura El hawary <nelhawar>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 3.4   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-10-23 19:21:25 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 514793    
Attachments:
Description Flags
Patch to fix array ref error in sanitycheck.cgi (v1) nelhawar: review+

Description Noura El hawary 2009-09-22 11:11:32 UTC
running 
/sanitycheck.cgi?remove_invalid_bug_references=1

produces the error:
Software error:

Can't use string ("bug_cf_qa_status/") as an ARRAY ref while "strict refs" in use at /var/www/html/bugzilla-redhat/branches/upstream-3.4/sanitycheck.cgi line 456.

Comment 2 Noura El hawary 2009-10-22 13:02:14 UTC
Hi Dave,

with the problem in this bug basically the error is coming from the line 347 is sanitycheck.cgi which is:

my @addl_fields = map { 'bug_' . $_->name . '/' } @multi_selects;

I think the problem is coming from trying to access $->name in a Bugzilla::Field.pm object ..

This is how @multi_selects look like:
$VAR1 = [
          bless( {
                   'mailhead' => '0',
                   'sortkey' => '6600',
                   'custom' => '1',
                   'name' => 'cf_conditional_nak',
                   'description' => 'Conditional NAK',
                   'buglist' => '0',
                   'obsolete' => '0',
                   'visibility_value_id' => undef,
                   'value_field_id' => undef,
                   'visibility_field_id' => undef,
                   'enter_bug' => '0',
                   'public' => '0',
                   'id' => '66',
                   'type' => '3'
                 }, 'Bugzilla::Field' )
        ];

do you think that this is a merging issue? as what happened in the advanced search form? 

Thanks,
Noura

Comment 3 David Lawrence 2009-10-22 21:01:16 UTC
Created attachment 365782 [details]
Patch to fix array ref error in sanitycheck.cgi (v1)

Certainly seems like it could be a merge issue as we are finding in other places. 
I am attaching a patch that fixes the issue in our 3.4 tree by adding back some code that was removed from sanitycheck.cgi from 3.2->3.4. See if this fixes the problem for you.

Dave

Comment 4 Noura El hawary 2009-10-23 12:03:53 UTC
Comment on attachment 365782 [details]
Patch to fix array ref error in sanitycheck.cgi (v1)

perfect , thanks Dave. sanitycheck.cgi now passes the selenium test successfully now i can say that all the selenium testsuite passes our 3.4 code.

Noura

Comment 5 David Lawrence 2009-10-23 19:21:25 UTC
Thanks Noura. Checked in.