Bug 524888
| Summary: | Review Request: vecmath - The 3D vector math Java package, javax.vecmath | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Susi Lehtola <susi.lehtola> |
| Component: | Package Review | Assignee: | Gianluca Sforna <giallu> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, giallu, notting |
| Target Milestone: | --- | Flags: | giallu:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0-2.20090922cvs.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-10-21 00:37:51 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Susi Lehtola
2009-09-22 15:40:48 UTC
SPEC looks good, just some remarks: * You should refine the steps needed to create the tarball, the tar command is not correct and I had to do a "cvs login" before the "cvs checkout". this is correctly explained in https://vecmath.dev.java.net/servlets/ProjectSource. * I can't match the md5sum of the tarball, that's probably becasue xz is still a bit in "flux" or you used some options. If the former, please consider using the regular gz compression. I diffed the sources and thay match though. * please consider adding the "cvs" string the release field, it looks like a "SHOULD" in https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Snapshot_packages but often explicit is better than implicit. Fixed the above. http://theory.physics.helsinki.fi/~jzlehtol/rpms/vecmath.spec http://theory.physics.helsinki.fi/~jzlehtol/rpms/vecmath-0-2.20090922cvs.fc11.src.rpm ok, thank you, thank looks much better now. Of course, feel free to push upstream to do a proper release tarball (it does not look like there is much development there, it shouldn't be too hard to stick a release version label). Anyway: * package naming is correct * License tag is correct and acceptable * Sources matches upstream * builds in mock for F11 all the rest is pretty much identical to the java ant spec template at: http://fedoraproject.org/wiki/Packaging/Java#ant_2 this package is APPROVED Thanks for the review! New Package CVS Request ======================= Package Name: vecmath Short Description: The 3D vector math Java package, javax.vecmath Owners: jussilehtola Branches: F-10 F-11 EL-5 InitialCC: cvs done with F-12 branch added. vecmath1.2-1.14-5.fc10,vecmath-0-2.20090922cvs.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/vecmath1.2-1.14-5.fc10,vecmath-0-2.20090922cvs.fc10 vecmath1.2-1.14-5.fc11,vecmath-0-2.20090922cvs.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/vecmath1.2-1.14-5.fc11,vecmath-0-2.20090922cvs.fc11 vecmath-0-2.20090922cvs.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/vecmath-0-2.20090922cvs.el5 vecmath1.2-1.14-5.fc10, vecmath-0-2.20090922cvs.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update vecmath1.2 vecmath'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-10150 vecmath1.2-1.14-5.fc11, vecmath-0-2.20090922cvs.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update vecmath1.2 vecmath'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-10156 vecmath-0-2.20090922cvs.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update vecmath'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0571 vecmath1.2-1.14-5.fc11, vecmath-0-2.20090922cvs.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. vecmath1.2-1.14-5.fc10, vecmath-0-2.20090922cvs.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. vecmath-0-2.20090922cvs.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |