Bug 525210
| Summary: | Review Request: rubygem-trollop - A command-line option parsing library for ruby | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jan Klepek <jan.klepek> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, kmcmartin, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.15-1.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-10-04 16:07:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 525211 | ||
|
Description
Jan Klepek
2009-09-23 16:45:52 UTC
*** Bug 481523 has been marked as a duplicate of this bug. *** Well, the version is 1.14, 1.14.2.
For 1.14-0:
* License
- Well README says the license is the same as Ruby,
lib/trollop.rb says it is under GPLv2. So the license
tag should be "GPLv2"
* Redundant macro
- Is the definition of %ruby_sitelib needed?
* %check
- As this gem contains test/ directory, please add %check
stage and execute a test program.
* Directory ownership issue
- The directory %geminstdir itself is not owned by any packages.
Also please see my comments on bug 525211 comment 2 (In reply to comment #2) > Well, the version is 1.14, 1.14.2. > > For 1.14-0: > * License > - Well README says the license is the same as Ruby, > lib/trollop.rb says it is under GPLv2. So the license > tag should be "GPLv2" > > * Redundant macro > - Is the definition of %ruby_sitelib needed? > > * %check > - As this gem contains test/ directory, please add %check > stage and execute a test program. > > * Directory ownership issue > - The directory %geminstdir itself is not owned by any packages. -all fixed Spec URL: http://hpejakle.fedorapeople.org/packages/rubygem-trollop.spec SRPM URL: http://hpejakle.fedorapeople.org/packages/rubygem-trollop-1.14-1.fc11.src.rpm Well, upstream released 1.15, so please upgrade. updated Spec URL: http://hpejakle.fedorapeople.org/packages/rubygem-trollop.spec SRPM URL: http://hpejakle.fedorapeople.org/packages/rubygem-trollop-1.15-1.fc11.src.rpm Okay.
-------------------------------------------------------------
This package (rubygem-trollop) is APPROVED by mtasaka
-------------------------------------------------------------
New Package CVS Request ======================= Package Name: rubygem-trollop Short Description: A command-line option parsing library for ruby Owners: hpejakle Branches: F-10 F-11 F-12 EL-5 InitialCC: cvs done. rubygem-trollop-1.15-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/rubygem-trollop-1.15-1.fc11 rubygem-trollop-1.15-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/rubygem-trollop-1.15-1.fc10 rubygem-trollop-1.15-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/rubygem-trollop-1.15-1.el5 Please submit push request also for F-12 (now bodhi accepts push request for F-12). Closing. rubygem-trollop-1.15-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. rubygem-trollop-1.15-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. rubygem-ditz-0.5-4.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/rubygem-ditz-0.5-4.fc11 rubygem-ditz-0.5-4.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/rubygem-ditz-0.5-4.el5 rubygem-ditz-0.5-4.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/rubygem-ditz-0.5-4.fc12 rubygem-ditz-0.5-4.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/rubygem-ditz-0.5-4.fc10 rubygem-ditz-0.5-4.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. rubygem-ditz-0.5-4.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. rubygem-trollop-1.15-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |