Bug 525274
Summary: | Review Request: eclipse-callgraph - generates function call graph linked to Eclipse CDT | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Charley Wang <chwang> |
Component: | Package Review | Assignee: | Andrew Overholt <overholt> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | chitlesh, fedora-package-review, notting, overholt, rgrunber |
Target Milestone: | --- | Flags: | overholt:
fedora-review+
dennis: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-10-06 14:09:37 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Charley Wang
2009-09-23 19:11:12 UTC
Additional information: This is a joint project between myself and Roland Grunberg. It is our first package, and we are in need of a sponsor :) Roland will be posting alternate URLs shortly (i.e. URLs that are not hosted on the Fedora wiki, sorry about that) -Charley can you please verify if your plugin works under fedora's eclipse 3.5 on rawhide ? The plugins that I package are not loading on eclipse 3.5 ,see bug https://bugzilla.redhat.com/show_bug.cgi?id=523928 Updated URLs to the Spec, and SRPM files : Spec URL : http://akurtakov.fedorapeople.org/stap/Eclipse-callgraph.spec SRPM URL : http://akurtakov.fedorapeople.org/stap/Eclipse-callgraph-0.0.1-1.fc11.src.rpm Description: C/C++ Call Graph Visualization Tool After some more updates : URLs to the Spec, and SRPM files : Spec URL : http://akurtakov.fedorapeople.org/stap/eclipse-callgraph.spec SRPM URL : http://akurtakov.fedorapeople.org/stap/eclipse-callgraph-0.0.1-1.fc11.src.rpm Thanks for the submission. I know you used RPM Stubby to generate the .spec from an Eclipse feature.xml and it did a nice job :) There are only a few issues with the review and they're listed below on the lines beginning with an X. Please fix them, bump the release and add a comment in your .spec, and post new .spec and SRPM URLs here. Once I've verified it's fixed, we can move along with the process. Thanks. X please add a comment about the installation location (see below; the part about /usr/lib, dependencies, etc.) X please capitalize the beginning of your changelog entry Rest of review: - licensing good - fetch script is fine (contents match when I generate it myself) - BRs/Rs okay - macro usage fine - %files fine - builds and runs fine - rpmlint not okay (but see above): $ rpmlint eclipse-callgraph-0.0.1-1.fc11.i586.rpm eclipse-callgraph.i586: E: no-binary eclipse-callgraph.i586: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 1 errors, 1 warnings. - the warning is fine (we have to have this be arch-dependent due to its dependence on the arch-dependent CDT and therefore it must be in %{_libdir}) - there is no binary for the same reason as above $ rpmlint eclipse-callgraph-0.0.1-1.fc11.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Updated srpm and spec URL's: SRPM: http://akurtakov.fedorapeople.org/stap/eclipse-callgraph-0.0.1-2.fc11.src.rpm SPEC: http://akurtakov.fedorapeople.org/stap/eclipse-callgraph.spec Thanks. The %changelog entries should be more descriptive in the future but I'll let it slide this time. Approved. I think you need to make this block FE-NEEDSPONSOR, right? I've sponsored Charley. Charley, please go ahead with https://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure. New Package CVS Request ======================= Package Name: eclipse-callgraph Short Description: C/C++ Call Graph Visualization Tool Owners: chwang rgrunber Branches: InitialCC: chwang rgrunber akurtakov overholt New Package CVS Request ======================= Package Name: eclipse-callgraph Short Description: C/C++ Call Graph Visualization Tool Owners: chwang rgrunber Branches: InitialCC: chwang rgrunber akurtakov overholt (Modified, sorry for the triple post) New Package CVS Request ======================= Package Name: eclipse-callgraph Short Description: C/C++ Call Graph Visualization Tool Owners: chwang Branches: InitialCC: chwang rgrunber akurtakov overholt CVS Done |