Bug 525304
Summary: | Review Request: notification-daemon-engine-slider - The Slider theme engine for the notification daemon | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | jmccann |
Component: | Package Review | Assignee: | Matthias Clasen <mclasen> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | cschalle, fedora-package-review, mclasen, notting |
Target Milestone: | --- | Flags: | mclasen:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-09-25 00:51:42 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
jmccann
2009-09-23 20:41:45 UTC
package builds fine in mock rpmlint output: [mclasen@planemask ~]$ rpmlint /var/lib/mock/fedora-rawhide-i386/result/notification-daemon-engine-slider-*.rpm notification-daemon-engine-slider.i586: E: zero-length /usr/share/doc/notification-daemon-engine-slider-0.1.0/NEWS notification-daemon-engine-slider.i586: E: zero-length /usr/share/doc/notification-daemon-engine-slider-0.1.0/README notification-daemon-engine-slider.i586: E: zero-length /usr/share/doc/notification-daemon-engine-slider-0.1.0/AUTHORS notification-daemon-engine-slider-debuginfo.i586: E: description-line-too-long This package provides debug information for package notification-daemon-engine-slider. 3 packages and 0 specfiles checked; 4 errors, 0 warnings. Should probably remove the empty files, or make them nonempty formal review: rpmlint: see above package name: ok spec file name: ok packaging guidelines: ok license: ok license field: ok license file: ok spec language: ok spec legible: ok upstream sources: ok buildable: ok excludearch: n/a build deps: ok locale handling: n/a shared libs: ok bundling: ok directory ownership: ok duplicate files: ok file permissions: ok %clean: ok macro use: ok content: ok large docs: n/a %doc content: ok, but see about about empty files headers: n/a static libs: n/a shared libs: n/a devel deps: ok libtool archives: ok gui apps: n/a file ownership: ok %install: ok utf8 filenames: ok Looks ok. Just take care of the empty files. Approved. Ok updated to fix the empty files. Requesting cvs. New Package CVS Request ======================= Package Name: notification-daemon-engine-slider Short Description: The Slider theme engine for the notification daemon Owners: mccann Branches: InitialCC: cvs done. The package has been built |