Bug 525808
| Summary: | Review Request: pigz - Parallel implementation of gzip | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adel Gadllah <adel.gadllah> |
| Component: | Package Review | Assignee: | Toshio Ernie Kuratomi <a.badger> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | a.badger, fedora-package-review, guido.grazioli, notting, orion, pahan |
| Target Milestone: | --- | Flags: | a.badger:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-09-26 08:20:04 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Adel Gadllah
2009-09-25 20:32:36 UTC
Good: * Naming follows the packaging guidelines * license is contained in README and README is included in the documentation * Spec file is readable * Source matches with source from canonical upstream * No locales * Not a library * No bundled libraries * Not relocatable * Directories created by package and no others are owned * No duplicate files listed * Permissions set properly * Proper %clean * Macros used consistently * Code, not content * No %doc files affect program runtime * No subpackages * Not a GUI app * rm -rf run properly at beginning of %install * Filenames are valid utf-8 * Package builds in koji * rpmlint clean * Tested that pigz compresses a file that can be decompressed by gzip and vice versa Needswork: * license should be "zlib" Providing you change the license when you import the package, this package is APPROVED. (In reply to comment #1) > Good: > * Naming follows the packaging guidelines > * license is contained in README and README is included in the documentation > * Spec file is readable > * Source matches with source from canonical upstream > * No locales > * Not a library > * No bundled libraries > * Not relocatable > * Directories created by package and no others are owned > * No duplicate files listed > * Permissions set properly > * Proper %clean > * Macros used consistently > * Code, not content > * No %doc files affect program runtime > * No subpackages > * Not a GUI app > * rm -rf run properly at beginning of %install > * Filenames are valid utf-8 > * Package builds in koji > * rpmlint clean > * Tested that pigz compresses a file that can be decompressed by gzip and > vice versa > > Needswork: > * license should be "zlib" oh ok. > Providing you change the license when you import the package, this package is > APPROVED. Sure, thanks for the review. New Package CVS Request ======================= Package Name: pigz Short Description: Parallel implementation of gzip Owners: drago01 Branches: F-10 F-11 InitialCC: cvs done. (In reply to comment #4) > cvs done. Thanks, package imported and built. Adel, you miss the -p in the install command to preserve timestamps (In reply to comment #6) > Adel, you miss the -p in the install command to preserve timestamps Good catch, fixed in 2.1.5-3 thanks. Can we get EL branches made? I'd be willing to maintain them if needed. Package Change Request ====================== Package Name: pigz New Branches: EL-5 Owners: orion (In reply to comment #8) > Can we get EL branches made? I'd be willing to maintain them if needed. Sure go ahead. CVS done. |