Bug 525831 (vim-perl-tt2)
| Summary: | Review Request: vim-perl-tt2 - Syntax highlighting for the Template-Toolkit | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
| Component: | Package Review | Assignee: | Emmanuel Seyman <emmanuel> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | emmanuel, fedora-package-review, notting, susi.lehtola |
| Target Milestone: | --- | Flags: | emmanuel:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://www.vim.org/scripts/script.php?script_id=830 | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-10-08 15:54:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Chris Weyl
2009-09-26 04:15:38 UTC
You need Requires: vim-common for dir ownership. We were requiring vim-perl-support (which in turn requires vim-common), but on second thought that seemed a bit.... heavy. I've replace the vim-perl-support req with vim-common. Spec URL: http://fedorapeople.org/~cweyl/review/vim-perl-tt2.spec SRPM URL: http://fedorapeople.org/~cweyl/review/vim-perl-tt2-0.1.3-2.fc11.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1714911 (In reply to comment #3) > > Spec URL: http://fedorapeople.org/~cweyl/review/vim-perl-tt2.spec This still contains the vim-perl-support req. > SRPM URL: > http://fedorapeople.org/~cweyl/review/vim-perl-tt2-0.1.3-2.fc11.src.rpm 404 Huh, weird. They're both out there now, in any case. Let's see what this is about. Review: + package builds in mock (dist-f13 i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1729479 + rpmlint issues a warning for the RPMS, is silent for the SRPM vim-perl-tt2.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings. + source files match upstream url 3e70d82171456550855a8b9612226c11 tt2.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is not included in package. + %doc is not present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does not create any directories. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application Looks good to me (shame about the lack of documentation, though). APPROVED. New Package CVS Request ======================= Package Name: vim-perl-tt2 Short Description: Syntax highlighting for the Template-Toolkit Owners: cweyl Branches: F-10 F-11 F-12 devel InitialCC: cvs done. Thanks for the review! :-) |