Bug 526045

Created attachment 362895 [details]
Proposed patch

Description of problem:

The option "raise_on_click", when disabled, prevents applications from changing the stacking order.

While this behavior may be in line with the description of the option in GConf, it does not sound right to correlate this option (wich is for user clicks) with intercepting XConfigureRequest() from the application.

Many legacy applications still use XRaiseWindow() or XConfigureWindow() to raise their windows and this should work unless "disable_workarrouds" is set (independently of "raise_on_click")

Version-Release number of selected component (if applicable):

metacity 2.16 (but also in current upstream)

How reproducible:

100% reproducible

Steps to Reproduce:
1. In Red Hat Enterprise Linux 5, run gconf-editor and unselect "raise_on_click" and set focus to "mouse" or "sloppy"

2. Run Thunderbird and open the the address book (control + 2)
3. Raise and focus the main window, keeping the addressbook window open but lowered and unfocused
4. Reopen the address book (either from menu "tools" -> "Address book" or with the shortcut "ctrl+2")
  
Actual results:

The addressbook is not raise and not focused

Expected results:

The addressbook is raised, maybe focused if the pointer is within the window.

Additional info:

In meta_window_configure_request() from src/window.c, if raise_on_click is not set, the request is ignored unconditionally:

meta_window_configure_request()
{
  [...]
  if (event->xconfigurerequest.value_mask & CWStackMode)
    {
      MetaWindow *active_window;
      active_window = window->display->expected_focus_window;
      if (meta_prefs_get_disable_workarounds () ||
          !meta_prefs_get_raise_on_click ())

        {
          meta_topic (META_DEBUG_STACK,
                      "%s sent an xconfigure stacking request; this is "
                      "broken behavior and the request is being ignored.\n",
                      window->desc);
        }
  [...]

This is not the same as bug 503522 (and actually prevent any fix for bug 503522 to work if raise_on_click is unset)

The attached patch from out customer removes that test for !meta_prefs_get_raise_on_click () so that the behavior is consistent even if raise_on_click is unset.

Please also not that the reproducer is with Thunderbird, although recent version of Thunderbird now rightfully use net_window_activate, but many legacy application (not EWMH compliant) are impacted by this issue.