Bug 528094
| Summary: | qt webkit crash on drag | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | William Witt <william> | ||||
| Component: | qt | Assignee: | Rex Dieter <rdieter> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 11 | CC: | kevin, ltinkl, rdieter, than | ||||
| Target Milestone: | --- | Keywords: | Patch, Triaged | ||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-12-20 08:13:45 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
William Witt
2009-10-09 02:05:39 UTC
Created attachment 364191 [details]
patch to fix webkit drag crash
patch taken from git://gitorious.org/qt/qt.git commit 9dadc219814cd9baaa4be4cee6ee2b3cf7df4a19
git log is as follows:
commit 9dadc219814cd9baaa4be4cee6ee2b3cf7df4a19
Author: Simon Hausmann <simon.hausmann>
Date: Fri Jul 24 10:22:11 2009 +0200
Updated WebKit from /home/shausman/src/webkit/trunk to origin/qtwebkit-4.5 ( eb3afcbfb4006de4015047555cb256fcde93b954 )
Changes in WebKit since the last update:
++ b/WebCore/ChangeLog
2009-05-27 John Sullivan <sullivan>
fixed <rdar://problem/6925482> repro crash in WebCore::DragController::dragExited dropping
bookmarks (at least) over Top Sites (at least)
Reviewed by Kevin Decker
* page/DragController.cpp:
(WebCore::DragController::dragExited):
nil check m_documentUnderMouse and take the "local file" case if it's nil
I can't reproduce any crash here. ?? $ rpm -q arora qt arora-0.10.1-1.fc11.x86_64 qt-4.5.2-21.fc11.x86_64 Where did you get qt-4.5.2-21.fc11.x86_64? The newest qt in the F11 repositories is qt-4.5.2-3.fc11 which does have the bug. Oh, yeah, my own backported build of what's currently in F-12/rawhide. Still, the bug *should* still be present there. Do you have a recipe to reproduce the crash? In the meantime, the patch looks fairly sane, but I'd rather have comment from one of my fellow qt maintainers before applying it. If you want to test for yourself, the newer experimental qt builds are here: http://kde-redhat.unl.edu/apt/kde-redhat/fedora/11/ in the unstable repo Tested with qt from http://kde-redhat.unl.edu/apt/kde-redhat/fedora/11/ and can still reproduce. Please try the following: -open arora (I use arora from git, but the bug was present using 0.9.0 and 0.10.0 as well) -click and drag a bookmark from the bookmark bar. -drag the bookmark over the webview and back out. -arora will crash. The patch is backported code from qt-4.5.3 if it make review any easier. > -arora will crash. confirmed, thanks for the test-case. > The patch is backported code from qt-4.5.3 oh cool, that puts me at ease then. will apply. * Fri Oct 09 2009 Rex Dieter <rdieter> - 4.5.2-25 - qt webkit crash on drag (#528094) If the fix is already in 4.5.3, the best solution would be to get Qt 4.5.3 out ASAP (but of course we need to sort out that translations mess). But sure, backporting fixes from 4.5.3 to 4.5.2 is safe. the fix is already included in 4.5.3. It's been a while. I din't realize the bug report was still open. Verified fixed with current Fedora 12 |