Bug 528125

Builds in mock, rpmlint silent.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1733355

1.) Please do not repeat %attr-s, use %defattr instead, such as %defattr(0644,root,root,0755)

2.) Don't duplicate RPM's work when installing documentation.
Replace

cp -rp usr/share/doc/*				%{buildroot}/%{_defaultdocdir}/
...
%attr(644,root,root) %doc %{_defaultdocdir}/*/*

with something like "%doc usr/share/doc/*"

3.) mysql-zrm-socket-server service runs as mysql:mysql user. Shouldn't your files in /var be writable by that user?

4.) mysql-zrm-socket-server xinetd service is enabled by default. Should be disabled.

(In reply to comment #2)
> 1.) Please do not repeat %attr-s, use %defattr instead, such as
> %defattr(0644,root,root,0755)

Hope it's fixed. I left them only on necessary places, that may be broken in original package.
 
> 2.) Don't duplicate RPM's work when installing documentation.
> Replace
> 
> cp -rp usr/share/doc/*    %{buildroot}/%{_defaultdocdir}/
> ...
> %attr(644,root,root) %doc %{_defaultdocdir}/*/*
> 
> with something like "%doc usr/share/doc/*"  

done

(In reply to comment #3)
> 3.) mysql-zrm-socket-server service runs as mysql:mysql user. Shouldn't your
> files in /var be writable by that user?

Changed ownership of /var/log/mysql-zrm, but not /var/lib/mysql-zrm. I believe that it's dependent on local backup settings, which user will run backup jobs from crontab.

> 4.) mysql-zrm-socket-server xinetd service is enabled by default. Should be
> disabled.  

done

Spec URL: http://v3.sk/~xyzz/rpm/MySQL-zrm/MySQL-zrm.spec
SRPM URL: http://v3.sk/~xyzz/rpm/MySQL-zrm/MySQL-zrm-2.1.1-3.fc11.src.rpm

Seems better now, I don't see any more blockers.

5.) Please replace %{_var}/lib with %{_sharedstatedir}

6.) These two requires don't seem to be in fact required, please consider removing them:

Requires:	perl(Data::Report::Base) 
Requires:	perl(Data::Report::Plugin::Csv) 

APPROVED

(In reply to comment #5)
> Seems better now, I don't see any more blockers.
> 
> 5.) Please replace %{_var}/lib with %{_sharedstatedir}
> 
> 6.) These two requires don't seem to be in fact required, please consider
> removing them:
> 
> Requires: perl(Data::Report::Base) 
> Requires: perl(Data::Report::Plugin::Csv) 
> 
> APPROVED  

Fixed. Thanks for review.

Spec URL: http://v3.sk/~xyzz/rpm/MySQL-zrm/MySQL-zrm.spec
SRPM URL: http://v3.sk/~xyzz/rpm/MySQL-zrm/MySQL-zrm-2.1.1-3.fc11.src.rpm

New Package CVS Request
=======================
Package Name: MySQL-zrm
Short Description: MySQL backup manager
Owners: ksyz
Branches: F-11 F-12 EL-5
InitialCC:

cvs done.

thanks for cvs

MySQL-zrm-2.1.1-5.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/MySQL-zrm-2.1.1-5.fc11

MySQL-zrm-2.1.1-5.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/MySQL-zrm-2.1.1-5.fc12

MySQL-zrm-2.1.1-5.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/MySQL-zrm-2.1.1-5.el5

MySQL-zrm-2.1.1-5.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update MySQL-zrm'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-10458

MySQL-zrm-2.1.1-5.el5 has been pushed to the Fedora EPEL 5 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update MySQL-zrm'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0649

MySQL-zrm-2.1.1-5.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.

MySQL-zrm-2.1.1-5.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.