Bug 528223

Summary: hostssh alias with --bg breaks when "real" ssh is used
Product: [Fedora] Fedora Reporter: John Hein <txn2tahx3v>
Component: hotsshAssignee: Colin Walters <walters>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: 11CC: walters
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-06-28 14:59:09 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description John Hein 2009-10-09 20:56:05 UTC
Description of problem:

When hotssh is installed F10 & F11 define default aliases (csh & sh) for ssh that invoke hotssh with --bg (undocumented option except a comment in the hotssh script itself).

When you do something like 'ssh -i somekey user@host', it fails because the hotssh python script decides to run the "real" ssh, but does not strip off the --bg (which makes openssh die if --bg is the first argument).

Version-Release number of selected component (if applicable):

hotssh-0.2.6-1.fc10.noarch
hotssh-0.2.6-2.fc11.noarch


How reproducible:

always

Steps to Reproduce:
1. install hotssh
2. start a new shell that picks up the default alias from /etc/profile.d/hotssh.sh or hotssh.csh
3. run "ssh -i /path/to/key user@host"
  
Actual results:

usage: ssh [-1246AaCfgKkMNnqsTtVvXxY] [-b bind_address] [-c cipher_spec]
           [-D [bind_address:]port] [-e escape_char] [-F configfile]
           [-i identity_file] [-L [bind_address:]port:host:hostport]
           [-l login_name] [-m mac_spec] [-O ctl_cmd] [-o option] [-p port]
           [-R [bind_address:]port:host:hostport] [-S ctl_path]
           [-w local_tun[:remote_tun]] [user@]hostname [command]


Expected results:

ssh should attempt to open a connection to 'host'

Additional info:

Bug 477786  (similar, but the fix there doesn't help this problem)

I'm not sure it's useful to have the alias that redefines ssh to hotssh and adds --bg.  If people want to, they can just append '&' (granted not exactly the same as fork + setsid) or use something like the bsd daemon(8) or daemonize(1).

But in any case, it should not be there until the hotssh script can handle it properly (maybe by stripping --bg if calling the "real" ssh similar to how it strips --bg in the "non-real" ssh case?).

Comment 1 Bug Zapper 2010-04-28 10:46:29 UTC
This message is a reminder that Fedora 11 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 11.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '11'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 11's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 11 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 2 John Hein 2010-05-24 16:36:20 UTC
This was fixed upstream by removing the alias...

http://git.gnome.org/browse/hotssh/commit/?id=e4aeeb6cc1597bb7c518906f04902e601dc7a166

This appears to have been pulled into Fedora 12, but not Fedora 11.

Comment 3 John Hein 2010-05-24 16:41:49 UTC
Also see https://bugzilla.gnome.org/show_bug.cgi?id=577801

Comment 4 Bug Zapper 2010-06-28 14:59:09 UTC
Fedora 11 changed to end-of-life (EOL) status on 2010-06-25. Fedora 11 is 
no longer maintained, which means that it will not receive any further 
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of 
Fedora please feel free to reopen this bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.