Bug 529063

Summary: qla2xxx flash programming changes in 4.8 broke diskdump
Product: Red Hat Enterprise Linux 4 Reporter: Dave Maley <dmaley>
Component: kernelAssignee: Takao Indoh <tindoh>
Status: CLOSED ERRATA QA Contact: Chao Ye <cye>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 4.9CC: bdonahue, coughlan, dhoward, emcnabb, fge, lwang, moshiro, qcai, revers, tao, vgoyal
Target Milestone: rcKeywords: Regression, ZStream
Target Release: 4.9   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
A fix in the Red Hat Security Advisory RHSA-2009:1024 introduced a regression which caused the diskdump command to fail on systems with certain adapters using the qla2xxx driver. With this update, diskdump now works as expected.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2011-02-16 15:25:39 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 485811, 577232, 577234, 578858, 589296    
Attachments:
Description Flags
patch proposed by partner
none
Proposed patch from IT#349345
none
Updated patch
none
Update driver version to 8.02.09.01.04.09-d
none
Updated verison to 8.02.10.00.04.09-d none

Description Dave Maley 2009-10-14 19:52:30 UTC 
Created attachment 364801 [details]
patch proposed by partner

Description of problem:
Partner reports that the qla2xxx flash programming fix (bug 491784) added in 4.8 has broke diskdump on systems w/ qla2xxx hba's.  The patch:

linux-2.6.9-qla2xxx-fix-flash-program-fix-read-write-version-u.patch

..adds qla2xxx_schedule_udelay which includes a schedule() call.  This won't work during diskdump and thus causes a hang.

Partner has provided the attached patch, which they've tested and confirmed it fixes this regression.


<from Partner>

We installed RHEL4.8 and configured diskdump. We executed the following command and we tried to start diskdump:

 # echo c > /proc/sysrq-trigger

But, After that,the system did hang and diskdump failed.

The diskdump failed because the qla driver(qla_sup.c) didn't consider the prohibit operation during diskdump for RHEL4.x

The function schedule() can not be used during diskdump operation for RHEL4.X because the interrupt operation is prohibited during diskdump operations for RHEL4.x. The function schedule() is an interrupt function. But, Schedule() is used in the qla driver(qla_sup.c) of RHEL4.8.

The qla driver of RHEL4.8 should be fixed not to use the interrupt function prohibited during diskdump operation.

We provide the patch to solve this problem and confirmed that the problem is solved by our patch. Please include our patch and fix this bug in RHEL4.8 erratum.


Version-Release number of selected component (if applicable):
kernel-2.6.9-89.EL


How reproducible:
often


Steps to Reproduce:
1. configure diskdump w/ DEVICE pointed to target connected to qla2xxx hba
2. initialize dump device
3. start diskdump service
4. crash system


Actual results:
diskdump hangs


Expected results:
diskdump completes, vmcore captured


Additional info:
Comment 4 Takao Indoh 2010-03-10 22:40:44 UTC 
Created attachment 399198 [details]
Proposed patch from  IT#349345

Thanks for the patch, it looks good.

Takao Indoh
Comment 5 Takao Indoh 2010-03-16 19:50:50 UTC 
Created attachment 400546 [details]
Updated patch

During building a kernel with the proposed patch, I found some warning message. 

/usr/src/redhat/BUILD/kernel-2.6.9/linux-2.6.9/drivers/scsi/qla2xxx/qla_sup.c: In function `qla2xxx_schedule_udelay':
/usr/src/redhat/BUILD/kernel-2.6.9/linux-2.6.9/drivers/scsi/qla2xxx/qla_sup.c:39: warning: implicit declaration of function `diskdump_update'

So I update this patch so that linux/diskdump.h is included.
Comment 8 Lalit Chandivade 2010-03-31 17:36:43 UTC 
Created attachment 403792 [details]
Update driver version to 8.02.09.01.04.09-d
Comment 9 Lalit Chandivade 2010-04-01 02:21:20 UTC 
Created attachment 403848 [details]
Updated verison to 8.02.10.00.04.09-d
Comment 10 Vivek Goyal 2010-04-05 19:31:06 UTC 
Committed in 89.22.EL . RPMS are available at http://people.redhat.com/vgoyal/rhel4/
Comment 12 Vivek Goyal 2010-04-12 21:30:12 UTC 
qla noticed that version of qla driver committed with the previous patch is not the right one. They have sent in a new patch to reflect the right version. Hence putting this bz back in POST state so that new patch also can be committed against this bz.
Comment 13 Vivek Goyal 2010-04-14 15:05:20 UTC 
Committed in 89.23.EL . RPMS are available at http://people.redhat.com/vgoyal/rhel4/
Comment 16 Qian Cai 2010-05-15 03:36:53 UTC 
*** Bug 578858 has been marked as a duplicate of this bug. ***
Comment 22 Douglas Silas 2011-01-30 22:52:52 UTC 
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
A fix in the Red Hat Security Advisory RHSA-2009:1024 introduced a regression which caused the diskdump command to fail on systems with certain adapters using the qla2xxx driver. With this update, diskdump now works as expected.
Comment 23 errata-xmlrpc 2011-02-16 15:25:39 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0263.html