Bug 529253

Summary: Review Request: dmenu - Generic menu for X
Product: [Fedora] Fedora Reporter: Simon <cassmodiah>
Component: Package ReviewAssignee: Andreas Osowski <th0br0>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, i, notting
Target Milestone: ---Keywords: Reopened
Target Release: ---Flags: th0br0: fedora-review+
gwync: fedora-cvs+
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 4.0-2.fc12 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-12-24 20:40:23 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Simon 2009-10-15 19:19:06 UTC
Spec URL:
http://cassmodiah.fedorapeople.org/dmenu/dmenu.spec

SRPM URL:
http://cassmodiah.fedorapeople.org/dmenu/dmenu-4.0-0.1.fc11.src.rpm

Description:
dynamic menu is a generic menu for X, originally designed for dwm. It manages 
huge amounts (up to 10.000 and more) of user defined menu items efficiently.

Comment 1 Jason Tibbitts 2009-10-15 22:21:14 UTC
Perhaps you could help with the existing review ticket for this package.

*** This bug has been marked as a duplicate of bug 485638 ***

Comment 3 Andreas Osowski 2009-12-22 11:57:47 UTC
Package Review
==============

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format 
%{name}.spec.
 [x] Package meets the Packaging Guidelines
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: 
       [x] F12/i686 
 [x] Rpmlint output:
     Source RPM:
	1 packages and 0 specfiles checked; 0 errors, 0 warnings. 
     Binary RPM(s):
 	1 packages and 0 specfiles checked; 0 errors, 0 warnings.
 [x] Package is not relocatable.
 [x] Buildroot is correct
 %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined   in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type: MIT
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file,     containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided 
     in the spec URL.
     SHA1SUM of package: 6fb1ff6e414d5ef33d2f627b0ec563eaac19fbd8
 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that 
     are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [-] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains rm -rf %{buildroot}.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI 
     application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains 
     translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: F12/i686
 [-] Package should compile and build into binary rpms on all supported 
     architectures.
     Tested on: -
 [-] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.  

Remaining issues:
NONE.


**********************
****** APPROVED ******
**********************

             *
            /.\
           /..'\
           /'.'\
          /.''.'\
          /.'.'.\
   "'""""/'.''.'.\""'"'"
     jgs ^^^[_]^^^
 
:)

Comment 4 Simon 2009-12-22 12:18:49 UTC
nice ascii
thx for your review

New Package CVS Request
=======================
Package Name:  dmenu
Short Description: Generic menu for X
Owners: cassmodiah
Branches: F-12
InitialCC:

Comment 5 Dennis Gilmore 2009-12-23 19:46:49 UTC
CVS Done

Comment 6 Fedora Update System 2009-12-23 20:25:34 UTC
dmenu-4.0-2.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/dmenu-4.0-2.fc12

Comment 7 Fedora Update System 2009-12-24 20:40:18 UTC
dmenu-4.0-2.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Simon 2010-06-23 12:10:53 UTC
Package Change Request
======================
Package Name: dmenu
New Branches: EL-6
Owners: cassmodiah

Comment 9 Jason Tibbitts 2010-06-26 21:22:27 UTC
CVS done (by process-cvs-requests.py).

Comment 10 Christopher Meng 2014-04-25 01:43:37 UTC
Package Change Request
======================
Package Name: dmenu
New Branches: epel7
Owners: cicku

Comment 11 Gwyn Ciesla 2014-04-25 12:21:51 UTC
Git done (by process-git-requests).