Bug 529560 (mingw32-libvorbis)
Summary: | Review Request: mingw32-libvorbis - MinGW build of the libvorbis Vorbis General Audio Compression Codec library | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Mihai Limbășan <mihai> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | fedora-mingw, fedora-package-review, josh, mihai, notting, rjones |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-12-17 15:25:02 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 529548 | ||
Bug Blocks: | 201449 |
Description
Mihai Limbășan
2009-10-18 17:01:18 UTC
Looks sane. Same comment about packaging the static library. If you want to get these reviewed, you'll have to ask someone nicely on the fedora-mingw / fedora-devel-list mailing lists, and probably swap a review with someone. Thanks, will do. Improved package, bumped revision. New URLs: Spec URL: http://rpms.limbasan.ro/fedora/11/SPECS/mingw32-libvorbis.spec SRPM URL: http://rpms.limbasan.ro/fedora/11/SRPMS/mingw32-libvorbis-1.2.3-3.fc11.src.rpm Changes as follows: - Removed -static package. - aclocal and pkgconfig directories under _mingw32_libdir are no longer installed, mingw32-filesystem already provides them. - Removed redundant BuildRequire mingw32-binutils which is already Required by mingw32-gcc. - Moved checks to the proper build stage. - Cosmetic cleanup. rpmlint says: [mimock@home mingw32-libvorbis]$ rpmlint -v *rpm mingw32-libvorbis.noarch: I: checking mingw32-libvorbis.src: I: checking 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Again no Koji link due to dependency on mingw32-libogg (bug #529548). Tests complete successfully, builds cleanly in mock. Your package submissions still build and they seem to me to be clean, but before putting in any review work I'd like to ask, since it's been over a year since anyone has looked at them, if you're still interested in submitting them. Please let me know; if so I'll try to move forward with reviews and sponsorship. |