Bug 529605

Spec URL: http://magoazul.com/wip/SPECS/ohai.spec
SRPM URL: http://magoazul.com/wip/SRPMS/ohai-0.3.2-2.fc12.src.rpm

* Wed Oct 21 2009 Matthew Kent <mkent> - 0.3.2-2
- Include man page.

Well, lib/ohai/mixin/command.rb is GPLv3+.
Would you ask the upstream if this is intentional?

The trouble is that this makes the whole ohai to be
under GPLv3+ (ASL 2.0 and GPLv3+ are compatible).
Then:

* rubygem-json - GPLv2 or Ruby
* rubygem-extlib - MIT
* rubygem-systemu - GPLv2 or Ruby
* ohai - GPLv3+

Since
- GPLv2 and GPLv3+ are incompatible
- Ruby and GPLv3+ are also incompatible
according to https://fedoraproject.org/wiki/Licensing ,
currently ohai is under license conflict.
if lib/ohai/mixin/command.rb is also changed to under ASL 2.0,
license conflict can be resolved.

For now setting FE-Legal

Hi, thank you for the review!

(In reply to comment #2)
> Well, lib/ohai/mixin/command.rb is GPLv3+.
> Would you ask the upstream if this is intentional?
>

I've asked them and they are discussing it.

Still waiting on the license issue.

Spec URL: http://magoazul.com/wip/SPECS/ohai.spec
SRPM URL: http://magoazul.com/wip/SRPMS/ohai-0.3.6-1.fc12.src.rpm

* Wed Oct 28 2009 Matthew Kent <mkent> - 0.3.6-1
- New upstream release.
- Add dependencies on rubygem-mixlib-{cli,config,log}
- man page included upstream

(In reply to comment #5)
> Still waiting on the license issue.
> 
> Spec URL: http://magoazul.com/wip/SPECS/ohai.spec
> SRPM URL: http://magoazul.com/wip/SRPMS/ohai-0.3.6-1.fc12.src.rpm
> 
> * Wed Oct 28 2009 Matthew Kent <mkent> - 0.3.6-1
> - New upstream release.
> - Add dependencies on rubygem-mixlib-{cli,config,log}
> - man page included upstream  

Apologies, this update is broken. I'm going to have to rework things a little.

Asking for advice on this package at 

https://www.redhat.com/archives/fedora-packaging/2009-October/msg00091.html

About your mail:
I would package this from gem (as it seems the simplest, I prefer
simpleness), and if non-gem support scripts on other packages can
be avoided, it is better. However I leave it to you how to package 
this software.

Still waiting on legal in http://tickets.opscode.com/browse/OHAI-137

(In reply to comment #8)
> About your mail:
> I would package this from gem (as it seems the simplest, I prefer
> simpleness), and if non-gem support scripts on other packages can
> be avoided, it is better. However I leave it to you how to package 
> this software.  

Thank you for your input. 

I agree it would be simpler to use the gem but after some discussion with upstream and having packaged it's main parent package, Chef, I think I'll pursue this submission with dependencies on rubygem-* packages (option b) for the time being.

So the legal issue is resolved by upstream and I've decided to take the path of least resistance and let rubygems do the work of installing as upstream hasn't added any kind of setup.rb system yet.

Spec URL: http://magoazul.com/wip/SPECS/rubygem-ohai.spec
SRPM URL: http://magoazul.com/wip/SRPMS/rubygem-ohai-0.5.0-1.fc14.src.rpm

rpmlint /var/tmp/results/rubygem-ohai-* | grep -v '/1.8/doc/'
rubygem-ohai.src: W: no-buildroot-tag
rubygem-ohai-doc.noarch: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 10 warnings.
(skipping the unexpanded-macro warnings in docs)

Build logs here http://koji.fedoraproject.org/koji/taskinfo?taskID=2068382

The only issue I can't decipher is a strange occasional failure in one extremely simple test within the test suite when run within the build root - something to do with Time. Can't reproduce it outside mock.

Well,
With ohai 0.3.2, $ ohai returned some information of my system.
0.3.6: not tested
With 0.5.0:

$ ohai
/usr/lib/ruby/1.8/logger.rb:314:in `<': comparison of Fixnum with :info failed (ArgumentError)
	from /usr/lib/ruby/1.8/logger.rb:314:in `add'
	from /usr/lib/ruby/1.8/logger.rb:348:in `debug'
	from /usr/lib/ruby/gems/1.8/gems/mixlib-log-1.0.3/lib/mixlib/log.rb:70:in `send'
	from /usr/lib/ruby/gems/1.8/gems/mixlib-log-1.0.3/lib/mixlib/log.rb:70:in `method_missing'
	from /usr/lib/ruby/gems/1.8/gems/ohai-0.5.0/lib/ohai/system.rb:200:in `require_plugin'
	from /usr/lib/ruby/gems/1.8/gems/ohai-0.5.0/lib/ohai/system.rb:190:in `each'
	from /usr/lib/ruby/gems/1.8/gems/ohai-0.5.0/lib/ohai/system.rb:190:in `require_plugin'
	from /usr/lib/ruby/gems/1.8/gems/ohai-0.5.0/lib/ohai/system.rb:116:in `all_plugins'
	from /usr/lib/ruby/gems/1.8/gems/ohai-0.5.0/lib/ohai/application.rb:89:in `run_application'
	from /usr/lib/ruby/gems/1.8/gems/ohai-0.5.0/lib/ohai/application.rb:67:in `run'
	from /usr/lib/ruby/gems/1.8/gems/ohai-0.5.0/bin/ohai:40
	from /usr/bin/ohai:19:in `load'
	from /usr/bin/ohai:19

Would you examine this?

(In reply to comment #11)
> With 0.5.0:
> 
> $ ohai
> /usr/lib/ruby/1.8/logger.rb:314:in `<': comparison of Fixnum with :info failed
> (ArgumentError)

My apologies I believe this is due to an older version mixlib-log, I've pushed new F-13 and rawhide versions that should fix that.

Alternately it's available here: http://magoazul.com/wip/x86_64/rubygem-mixlib-log-1.1.0-1.fc14.noarch.rpm or http://magoazul.com/wip/SRPMS/rubygem-mixlib-log-1.1.0-1.fc14.src.rpm if you prefer.

Thanks, now /usr/bin/ohai works.

Well,
- %ruby_sitelib macro doesn't seem to be needed

Other things are okay.
----------------------------------------------------------
  This package (rubygem-ohai) is APPROVED by mtasaka
----------------------------------------------------------

Thank you for the review!

New Package CVS Request
=======================
Package Name: rubygem-ohai
Short Description: Profiles your system and emits JSON
Owners: mkent
Branches: F-11 F-12 F-13
InitialCC:

CVS Done

rubygem-ohai-0.5.0-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/rubygem-ohai-0.5.0-1.fc12

rubygem-ohai-0.5.0-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/rubygem-ohai-0.5.0-1.fc13

rubygem-ohai-0.5.0-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/rubygem-ohai-0.5.0-1.fc11

Closing.

rubygem-ohai-0.5.0-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

rubygem-ohai-0.5.0-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

rubygem-ohai-0.5.0-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.