Bug 529756 (mingw32-libtheora)

Summary:	Review Request: mingw32-libtheora - MinGW build of the Theora Video Compression Codec library
Product:	[Fedora] Fedora	Reporter:	Mihai Limbășan <mihai>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-mingw, fedora-package-review, mihai, notting
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-12-17 15:25:33 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	529548
Bug Blocks:	201449

Description Mihai Limbășan 2009-10-19 19:54:07 UTC

Spec URL: http://rpms.limbasan.ro/fedora/11/SPECS/mingw32-libtheora.spec
SRPM URL: http://rpms.limbasan.ro/fedora/11/SRPMS/mingw32-libtheora-1.0-1.fc11.src.rpm
Description: This is a MinGW crosscompiler port of the libtheora package.

The spec file was created based on the example at

http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/3d9d4c1db042/example/mingw32-example.spec#l1

and on the main Fedora libtheora spec, taking into account the MinGW SIG packaging guidelines at http://fedoraproject.org/wiki/Packaging/MinGW and the spec files for the other packages depending on mingw32-libogg (e.g., bug #529560).

rpmlint output:

[mimock@home mingw32-libtheora]$ rpmlint -v *rpm
mingw32-libtheora.noarch: I: checking
mingw32-libtheora.src: I: checking
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

libtheora-undef-nonweak-symbols.patch is the first half of Fedora's libtheora-1.0beta3-~nweak-symbols.patch (patching lib/Makefile.in is redudant since we'll be regenerating it.)

libtheora-acconf.patch helps in replacing the ancient config.sub, config.guess, and libtool shipped by upstream with current versions.

The package builds cleanly in mock and its checks run properly (in ~/rpmbuild, checks can't currently be run in mock for MinGW packages.) 

The package does not provide the example CLI tools (encoder, decoder, PNG converter etc) thus doesn't depend on libpng, SDL, and/or libvorbis.

The package depends on mingw32-libogg (see bug #529548) which until accepted is available at the same test repo, http://rpms.limbasan.ro/fedora/11/i386/ .