Bug 529800

Summary: Target Milstone and Version lists fails to load values in the advanced search form
Product: [Community] Bugzilla Reporter: Noura El hawary <nelhawar>
Component: Query/Bug ListAssignee: Noura El hawary <nelhawar>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 3.4   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-10-21 15:12:55 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 514793    
Attachments:
Description Flags
v1 for fixing version and target milstone object values code in the search form
nelhawar: review? (dkl)
v2 for fixing version and target milstone object values code in the search form (backed down changes) nelhawar: review+

Description Noura El hawary 2009-10-20 06:01:51 UTC
Created attachment 365308 [details]
v1 for fixing version and target milstone object values code in the search form

running the test t/222_selenium_target_milestones.t revealed the problem that both the Target Milestone and Version multi select lists in the advanced search form fails to load their values. looking at the problem it turns out to be changed to the Version and Milestone objects in bugzilla 3.4 code, a fix for the issue is attached.

Comment 1 David Lawrence 2009-10-20 15:54:18 UTC
Sigh, this and other things we are finding leads me to believe that there was at one point a flaw in my method for syncing our code with the upstream BZR repository. The code parts that you are fixing are not like this in the stable 3.4 release but are in the trunk version. So somehow my upstream-3.4 branch has some bits from the trunk version merged in with the stable upstream 3.4 release. Which is not bad as long as me make the changes needed to make the newer code work with 3.4rh. But in this case I elect we make the parts of the template/query.cgi to match the stable 3.4 code for now and we will get the newer code when we merge in the future with 3.6 when released. I will attach a patch to back us down for your review.

Dave

Comment 2 David Lawrence 2009-10-20 15:55:59 UTC
Here are some links to illustrate what I mean in comment 1:

Upstream 3.4 template/en/default/search/form.html.tmpl
http://bzr.everythingsolved.com/bugzilla/3.4/annotate/head%3A/template/en/default/search/form.html.tmpl

Upstream Trunk template/en/default/search/form.html.tmpl
http://bzr.everythingsolved.com/bugzilla/trunk/annotate/head%3A/template/en/default/search/form.html.tmpl

Dave

Comment 3 David Lawrence 2009-10-20 15:57:04 UTC
Created attachment 365376 [details]
v2 for fixing version and target milstone object values code in the search form (backed down changes)

Comment 4 Noura El hawary 2009-10-21 11:21:59 UTC
Comment on attachment 365376 [details]
v2 for fixing version and target milstone object values code in the search form (backed down changes)

You patch looks good Dave, and it has solved the problem.

Thanks,
Noura

Comment 5 David Lawrence 2009-10-21 15:12:55 UTC
Thanks