Bug 530198
Summary: | Review Request: rubygem-columnize - Sorts an array in column order | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jeroen van Meeuwen <vanmeeuwen+fedora> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | ayoung, fedora-package-review, notting |
Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-12-23 15:55:04 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Jeroen van Meeuwen
2009-10-21 20:38:56 UTC
Some notes: * %check - Please add %check section as this package contains test/ directory * License - Well, while I believe this is under GPLv2+, "README" says this is under GPLv2, so it is safer that the license tag is changed to GPLv2. * %define -> %global - We now prefer to use %global rather than %define. * unused macro - The defined macro %ruby_sitelib does not seem to be used. Would you update this? ping? (In reply to comment #1) > Some notes: > > * %check > - Please add %check section as this package contains test/ > directory > Fixed. > * License > - Well, while I believe this is under GPLv2+, "README" says > this is under GPLv2, so it is safer that the license tag > is changed to GPLv2. > OK, fixed. > * %define -> %global > - We now prefer to use %global rather than %define. > Fixed. > * unused macro > - The defined macro %ruby_sitelib does not seem to be used. Fixed. New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-columnize.spec New SRPM: http://www.kanarip.com/custom/f12/SRPMS/rubygem-columnize-0.3.1-3.fc12.src.rpm Well, ------------------------------------------------------------- 37 # Fix shebangs 38 find %{buildroot}/%{geminstdir} -type f -exec sed -r -e 's"^#!(.*)/usr/bin/env ruby"#!/usr/bin/ruby"' {} \; ------------------------------------------------------------- - This should be "-exec sed -i -e". Other things are okay. ------------------------------------------------------------- This package (rubygem-columnize) is APPROVED by mtasaka ------------------------------------------------------------- New Package CVS Request ======================= Package Name: rubygem-columnize Short Description: Sorts an array in column order Owners: kanarip Branches: EL-5 F-11 F-12 InitialCC: cvs done. Closing. *** Bug 588429 has been marked as a duplicate of this bug. *** |