Bug 530301
| Summary: | Review Request: bmpanel2 - NETWM compliant panel for X | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marcus Moeller <marcus.moeller> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, mtasaka, notting, sandro |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 2.1-0.6.pre1.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-01-13 16:24:54 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Marcus Moeller
2009-10-22 09:10:23 UTC
Builds successfully on all archs for dist-f12: http://koji.fedoraproject.org/koji/taskinfo?taskID=1762702 2.1 pre1 seems released 4 days ago, which contains COPYING file. Would you have a plan to update to this? Updated to upstream version 2.1pre1: Spec URL: http://marcus-moeller.de/share/build/bmpanel2/2.1-0.1.pre1-1/bmpanel2.spec SRPM URL: http://marcus-moeller.de/share/build/bmpanel2/2.1-0.1.pre1-1/bmpanel2-2.1-0.1.pre1.fc11.src.rpm rpmlint SPECS/bmpanel2.spec RPMS/i586/bmpanel2-2.1-0.1.pre1.fc11.i586.rpm RPMS/i586/bmpanel2-debuginfo-2.1-0.1.pre1.fc11.i586.rpm SRPMS/bmpanel2-2.1-0.1.pre1.fc11.src.rpm 3 packages and 1 specfiles checked; 0 errors, 0 warnings. - Added python-devel build requirement - Fixed docbook stylesheet reference Spec URL: http://www.marcus-moeller.de/share/build/bmpanel2/2.1-0.2.pre1/bmpanel2.spec SRPM URL: http://www.marcus-moeller.de/share/build/bmpanel2/2.1-0.2.pre1/bmpanel2-2.1-0.2.pre1.fc11.src.rpm Builds fine in mock and Koji (sb: http://koji.fedoraproject.org/koji/taskinfo?taskID=1795775) Best Regards Marcus Well, * License - The following files (and perhaps the image files in the same directories) are under CC-BY-NC-SA, which is not accepted. https://fedoraproject.org/wiki/Licensing#Bad_Licenses_3 ------------------------------------------------------------------- CC-BY-NC-SA: ./themes/alduin-glossy/theme ./themes/alduin-smooth/theme ./themes/auriel-blue-opaque/theme ./themes/auriel-blue-smooth/theme ./themes/auriel-green-opaque/theme ./themes/auriel-green-smooth/theme ./themes/auriel-pink-opaque/theme ./themes/auriel-pink-smooth/theme ./themes/curvy-blue/theme ./themes/curvy-green/theme ./themes/curvy-pink/theme ./themes/flora-blue/theme ./themes/flora-green/theme ./themes/flora-pink/theme ./themes/striped/theme -------------------------------------------------------------------- First please remove these files from tarball. see: https://fedoraproject.org/wiki/Packaging/SourceURL#When_Upstream_uses_Prohibited_Code Also it is highly recommended to contact the upstream. Then some notes * Requires - "Requires: pango cairo" are redundant and should be removed, because these library related dependencies are automatically detected by rpmbuild itself and these dependencies are added to the rebuilt binary rpm. - Also "Requires: python" is unneeded because python(abi) dependency is automatically added (but please also see below) - For python related packages, please check the dependency for python-module related rpm by yourself. For example, /usr/bin/bmpanel2cfg contains: --------------------------------------------------------------------- 3 import bmpanel2 4 import gtk, gobject 5 from gtk import gdk --------------------------------------------------------------------- This means that -cfg package should have "Requires: pygtk2". * %changelog - As it is convenient when using Fedora CVS, it is recommended that you add one line between each %changelog entry like: --------------------------------------------------------------------- * Mon Nov 09 2009 Marcus Moeller <mmoeller> - 2.1-0.2.pre1 - Added python-devel build requirement - Fixed docbook stylesheet reference * Fri Nov 06 2009 Marcus Moeller <mmoeller> - 2.1-0.1.pre1 - Updated to upstream version 2.1pre1 - Seperated cfg package * Thu Oct 20 2009 Marcus Moeller <mmoeller> - 2.0.1a-1 - Initial Release --------------------------------------------------------------------- For now, blocking FE-Legal. Contacted Upstream. Is it perhaps possible not to include these themes within the resulting package? Best Regards Marcus (In reply to comment #7) > Is it perhaps possible not to include these themes within the resulting > package? Currently (i.e. unless the license of the files above changes), it is a must to remove those files from the srpm, and of course the rebuilt binary rpm must not include those files. If your question means "does this package work even without those themes?", perhaps it works because some other themes are not under CC-BY-NC-SA. Hi, Thanks for your reply. I know that it would work technically. I am going to rebuild the package without those themes. The author won't change the license of these files and he will also not remove them from the source package. Updated spec follows. Best Regards Marcus - Removed themes with legal problems from source tarball - Removed unnecessary Requires - Added pygtk2 requirement Spec URL: http://www.marcus-moeller.de/share/build/bmpanel2/2.1-0.3.pre1/bmpanel2.spec SRPM URL: http://www.marcus-moeller.de/share/build/bmpanel2/2.1-0.3.pre1/bmpanel2-2.1-0.3.pre1.fc11.src.rpm Best Regards Marcus Removing FE-Legal. Well
! For packaging issue:
* Desktop file
- rpms containing GUI applications should also include the corresponding
desktop files:
https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files
* Shebang
- From rpmlint:
--------------------------------------------------------------
bmpanel2-cfg.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/bmpanel2.py 0644 /usr/bin/env
--------------------------------------------------------------
bmpanel2.py contains shebang, however this file does not have
executionable permission. This script seems to be called from
/usr/bin/bmpanel2cfg only, so the shebang doesn't seem to be
needed and should be removed.
! For usability
- When I try bmpanel2:
---------------------------------------------------------------
[tasaka1@localhost ~]$ bmpanel2
(2.1pre1/bmpanel.c:158) Missing theme parameter, trying default "native"
FATAL (2.1pre1/panel.c:358) Too many widgets here, try to remove one or more
---------------------------------------------------------------
Is this normal? (note that I am using GNOME).
- I have now added a desktop file for bmpanel2cfg. IMHO it does not make much sense to add a desktop file for the panel itself. - Added Icon reference - Removed shebang / contacted upstream on that Spec URL: http://www.marcus-moeller.de/share/build/bmpanel2/2.1-0.4.pre1/bmpanel2.spec SRPM URL: http://www.marcus-moeller.de/share/build/bmpanel2/2.1-0.4.pre1/bmpanel2-2.1-0.4.pre1.fc11.src.rpm The application starts fine on my GNOME Box, just got the following errors if there is another widget active: (2.1pre1/bmpanel.c:158) Missing theme parameter, trying default "native" (2.1pre1/widget-systray.c:169) There is another tray selection owner, disabling tray (2.1pre1/panel.c:269) Failed to create widget: "systray" Best Regards Marcus Well, still I cannot launch bmpanel2 on GNOME, it launches
on XFCE, so I will continue this review request.
For -0.4:
* Source
- For source, please write the URL of the original source as a
comment, and rename the stripped tarball to like
"%{name}-%{upstream_version}-stripped.tar.gz" or so.
* icon cache updating
- Please follow
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache
( You are using the old template )
- As you are using %{_datadir}/icons/gnome/ (not %_datadir/icons/hicolor),
the scriptlet should also be using this directory.
Updated according to your advice. Spec URL: http://www.marcus-moeller.de/share/build/bmpanel2/2.1-0.5.pre1/bmpanel2.spec SRPM URL: http://www.marcus-moeller.de/share/build/bmpanel2/2.1-0.5.pre1/bmpanel2-2.1-0.5.pre1.fc11.src.rpm Concerning the error message you get while trying to start bmpanel2 from GNOME, I guess you got a lot of open systray apps: if (total_constants_width + total_separators_width > panel->width - min_fill_size) { XDIE("Too many widgets here, try to remove one or more"); } Best Regards Marcus For -0.5:
* Desktop icon
- I just reconsidered icon symlink treatment, and I found that
* leaving "Requires: gnome-icon-theme" as it is
* and replacing "Icon=bmpanel2cfg" in bmpanel2cfg.desktop with
"Icon=preferences-system-windows"
will suffice and all symlinks treatment in current bmpanel2.spec
is not needed. Also all scripts related to GTK icon cache update
should not be needed.
- Added preferences-system-windows icon reference to bmpanel2cfg.desktop - As icon cache re-generation seems to be unnecessary now, it has been removed Spec URL: http://www.marcus-moeller.de/share/build/bmpanel2/2.1-0.6.pre1/bmpanel2.spec SRPM URL: http://www.marcus-moeller.de/share/build/bmpanel2/2.1-0.6.pre1/bmpanel2-2.1-0.6.pre1.fc11.src.rpm I would prefer if you could sponsor me as the 'l7 review' associated with Christoph may still take some time. Best Regards Marcus For sponsorship issue, please wait for a moment. Well, should I wait until Christoph sponsors you or do you want me to sponsor you? ping? Christoph already sponsored me. Best Regards Marcus Okay, I confirmed that mmoeller is approved by cwickert ------------------------------------------------------- This package (bmpanel2) is APPROVED by mtasaka ------------------------------------------------------- Please follow the procedure written on: http://fedoraproject.org/wiki/PackageMaintainers/Join from "Install the Client Tools (Koji)". If you want to import this package into Fedora 9/10, you also have to look at http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT (after once you rebuilt this package on koji Fedora rebuilding system). ping? ping again? Hi, sorry for the late reply. Going to push this week. I was in holiday the past few days. Best Regards Marcus New Package CVS Request ======================= Package Name: bmpanel2 Short Description: NETWM-compatible panel for X11 Owners: mmoeller Branches: F-11 F-12 InitialCC: CVS done (by process-cvs-requests.py) bmpanel2-2.1-0.6.pre1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/bmpanel2-2.1-0.6.pre1.fc11 bmpanel2-2.1-0.6.pre1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/bmpanel2-2.1-0.6.pre1.fc12 Closing. bmpanel2-2.1-0.6.pre1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. bmpanel2-2.1-0.6.pre1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |