Bug 530910
| Summary: | Review Request: hyena - Hyena is a library of GUI and non-GUI C# code | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ryan Lerch <rlerch> |
| Component: | Package Review | Assignee: | Ismael Olea <ismael> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bnocera, claudiorodrigo, fedora-package-review, ian, ismael, notting, sebastian |
| Target Milestone: | --- | Flags: | ian:
fedora-review?
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-06-22 11:20:13 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 537640 | ||
|
Description
Ryan Lerch
2009-10-26 00:20:47 UTC
Please set the fedora-review flag to '?' if you are reviewing. (In reply to comment #1) > Please set the fedora-review flag to '?' if you are reviewing. Do i have to set that? or does the package reviewer? cheers, ryanlerch rpmlint doesn't like this. hyena.src: W: name-repeated-in-summary Hyena hyena.x86_64: W: name-repeated-in-summary Hyena hyena.x86_64: E: no-binary hyena.x86_64: W: devel-file-in-non-devel-package /usr/lib64/pkgconfig/hyena.pc hyena.x86_64: W: devel-file-in-non-devel-package /usr/lib64/pkgconfig/hyena.data.sqlite.pc hyena.x86_64: W: devel-file-in-non-devel-package /usr/lib64/pkgconfig/hyena.gui.pc hyena-debuginfo.x86_64: E: empty-debuginfo-package 3 packages and 0 specfiles checked; 2 errors, 5 warnings. It looks like it wants to be a noarch package. pkgconfig files need to go in a -devel subpackage. This is my first attempt to start becoming a packager. Any comment is welcome to learn I make changes to the file spec to work well, please check Spec URL: http://elsupergomez.fedorapeople.org/SPECS/hyena.spec SRPM URL: http://elsupergomez.fedorapeople.org/SRPMS/hyena-0.3-1.fc13.src.rpm Builds in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2247715 537639 is a duplicate, though it doesn't have a reviewer, or updated packages. *** Bug 537639 has been marked as a duplicate of this bug. *** I just update to upstream version 0.5 please check spec and src.rpm Spec URL: http://elsupergomez.fedorapeople.org/SPECS/hyena.spec SRPM URL: http://elsupergomez.fedorapeople.org/SRPMS/hyena-0.5-1.fc14.src.rpm Sorry, I've totally dropped off the face of the planet for this bug. Claudio, do you wish to maintain this package? If so, and Ryan doesn't object, add FE-NEEDSPONSOR to the blocker list above since you need a sponsor for the packager group. Claudio, Ryan: anyone plans to maintain it? (and the same with pdfmod https://bugzilla.redhat.com/show_bug.cgi?id=537640 ) I want maintain this package and pdfmod and poppler-sharp (In reply to comment #10) > Claudio, Ryan: anyone plans to maintain it? (and the same with pdfmod > https://bugzilla.redhat.com/show_bug.cgi?id=537640 ) I'll review them if you wish. poppler-sharp is used by another app? AFAIK sources are included in pdfmod, so I think is right to keep in one package for the moment. Yes please, I wish. I think at the moment no other package needs poppler-sharp. But pdfmod includes version 0.0.1 and is now available the 0.0.2 version ready for poppler 0.16 This library would be useful to program in monodevelop. The package is now ready for review in bug 607405. But as you seem to be more convenient. (In reply to comment #12) > I'll review them if you wish. > > poppler-sharp is used by another app? AFAIK sources are included in pdfmod, so > I think is right to keep in one package for the moment. Review of hyena-0.5-1.fc14.src.rpm from Claudio: * Compiling in F15 it needs mono-devel: BuildRequires: mono-devel * You should remove all the execution permisions for the files don't need it. * The setup -n parameter is redundant here * About %configure, I would not activate tests, as is not an in development version, but tests are not braking compilation so it's not necesary bad Please apply the suggested changes and use mock for next rebuilds for better control of potential collateral effects. @Ian: I can take over the review process if you wish, since it's related to #537640 and #607405. Go for it. I must have missed these messages a while ago. As I don't see any advance here I'm submiting the package as me. *** This bug has been marked as a duplicate of bug 834548 *** |