Bug 531051
| Summary: | Review Request: glite-security-util-java - Java Utilities for GSI Credentials | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Steve Traylen <steve.traylen> |
| Component: | Package Review | Assignee: | Mattias Ellert <mattias.ellert> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mattias.ellert:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | glite-security-util-java-2.7.1-1.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-11-13 21:01:18 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Steve Traylen
2009-10-26 16:55:48 UTC
Fedora review glite-security-util-java 2009-11-07
+ OK
- Needs work
? Needs explanation
$ rpmlint glite-security-util-java-*
glite-security-util-java.src:123: W: libdir-macro-in-noarch-package (main package) %attr(-,root,root) %{_libdir}/gcj/%{name}/%{name}-%{version}.jar.*
4 packages and 0 specfiles checked; 0 errors, 1 warnings.
+ rpmlint OK
+ Package named according to Java guidelines (name same as jarfile)
+ Specfile named after package
+ License tag "ASL 2.0 and EU Datagrid" is a Fedora apporved license
+ The tag corresponds to the license in the sources (most is ASL 2.0, but
the code in src/org/glite/security/voms/ac is EU Datagrid
+ LICENSE file is listed as %doc
+ Specfile is written in legible English
+ Sources corresponds to upstream (following the description in the specfile)
+ Package compiles as a mock build
+ Build requirements are sane
- The source tree contains an embedded copy of the source for the
vomsjapi library in src/org/glite/security/voms, bundling copies of
system libraries is not allowed - use the system version instead
This can be achieved by adding the following lines to the %prep section ...
rm -rf src/org/glite/security/voms
sed s/org.glite.security.voms.VOMSValidator/org.glite.voms.VOMSValidator/ \
-i src/org/glite/security/SecurityContext.java
... and adding vomsjapi to BuildRequires, Requires and build-classpath
It might then also be possible to change the License tag to only "ASL 2.0"
since the code under the other license is then not used.
- Package does not own /usr/lib64/gcj/glite-security-util-java
+ No duplicate files
+ Permissions are sane and %files has %defattr.
Though the %attr(-,root,root) tag for the gcj AOT files is redundant -
covered by the default.
+ %clean clears buildroot
+ Specfile uses macros consistently
+ Package contains code
- The javadoc package does not have a versioned directory and a symlink
+ Package does not own others' directories
+ %install clears buildroot
+ Filenames are UTF8
? axis and servlet are listed as BuildRequires but not as Requires - why?
New packages: http://cern.ch/straylen/rpms/glite-security-util-java/glite-security-util-java.spec http://cern.ch/straylen/rpms/glite-security-util-java/glite-security-util-java-2.0.3-6.fc11.src.rpm Removes the unneeded code and hence EU Datagrid license. Now includes /usr/lib64/gcj/glite-security-util-java explicitly. Documentation now in versioned directory with symlink. axis and servlet now Required as well. Forgotten. There is a typo in the Requires - should be vomsjapi:
Requires: vomjapi
The following line in the filelist is redundant - the parent directory is already listed:
%{_libdir}/gcj/%{name}/%{name}-%{version}.jar.*
Also there are several places in comments and changelog where it says vomsapi instead of vomsjapi:
# remove private copy of vomsapi and use the provided package.
- Don't use private vomsapi and use vomsapi package instead.
Thanks again, items in Comment #3 addressed. http://cern.ch/straylen/rpms/glite-security-util-java/glite-security-util-java.spec http://cern.ch/straylen/rpms/glite-security-util-java/glite-security-util-java-2.0.3-7.fc12.src.rpm Package approved. New Package CVS Request ======================= Package Name: stevetraylen Short Description: Java Utilities for GSI Credentials Owners: stevetraylen Branches: F-11 F-12 InitialCC: CVS done. Oops. "Package Name: stevetraylen". Can you confirm that the package name you actually wanted was glite-security-util-java and give me a revised CVS request? New Package CVS Request ======================= Package Name: glite-security-util-java Short Description: Java Utilities for GSI Credentials Owners: stevetraylen Branches: F-11 F-12 InitialCC: That will be why it will not checkout from CVS. Thanks yes the package name glite-security-util-java and apologies its such a long name, decided upstream. Steve CVS done (hopefully correctly this time). glite-security-util-java-2.0.3-7.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/glite-security-util-java-2.0.3-7.fc11 glite-security-util-java-2.0.3-7.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/glite-security-util-java-2.0.3-7.fc12 glite-security-util-java-2.0.3-7.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. glite-security-util-java-2.0.3-7.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: glite-security-util-java New Branches: EL-5 Owners: stevetraylen cvs done. glite-security-util-java-2.5.5-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/glite-security-util-java-2.5.5-1.el5 glite-security-util-java-2.7.1-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |