Bug 531082

Summary: RFE: add detection of Python 3 bytecode
Product: [Fedora] Fedora Reporter: Dave Malcolm <dmalcolm>
Component: fileAssignee: Daniel Novotny <dnovotny>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: dnovotny, mmalik
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 557608 809898 (view as bug list) Environment:
Last Closed: 2009-10-27 12:51:03 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 530636, 809898    
Attachments:
Description Flags
Add bytecode values for Python 3.0 and 3.1 none

Description Dave Malcolm 2009-10-26 20:14:20 UTC
Created attachment 366152 [details]
Add bytecode values for Python 3.0 and 3.1

Description of problem:
Attached is a patch that adds support for Python 3.0 and Python 3.1 bytecode files to the .pyc/.pyo support.

With this file:
$ file /usr/lib/python3.1/re.pyo
/usr/lib/python3.1/re.pyo: python 3.1 byte-compiled

Caveat: only tested with 3.1; I calculated up the value for 3.0 from the source in python's py3k branch's Python/import.c:
[snip]
       Python 3.0a5: 3130 (lexical exception stacking, including POP_EXCEPT)
[snip]
       Python 3.1a0: 3150 (optimize conditional branches:
			   introduce POP_JUMP_IF_FALSE and POP_JUMP_IF_TRUE)
[snip]

Note that the value has 1 added to it in py3k's _PyImport_Init,
giving:
  python 3.0: magic=3131 = 0x0c3b (hex) =  0x3b 0x0c 0xc0 0xd0a (header)
and 
  python 3.1: magic=3151 = 0x0c4f (hex) =  0x4f 0x0c 0x0d 0x0a (header)

Comment 1 Dave Malcolm 2009-10-26 20:17:38 UTC
>  python 3.0: magic=3131 = 0x0c3b (hex) =  0x3b 0x0c 0xc0 0xd0a (header)
should read:
>  python 3.0: magic=3131 = 0x0c3b (hex) =  0x3b 0x0c 0xc0 0x0a (header)

Comment 2 Dave Malcolm 2009-10-26 20:50:27 UTC
I've sent the patch to the upstream mailing list (file.com), but it's current stuck in the moderator queue as I'm not yet subscribed (they seem to require human intervention for approving subscriptions)

Comment 3 Daniel Novotny 2009-10-27 12:51:03 UTC
hello Dave, thanks for the patch, added in file-5.03-11.fc13

I am subscribed to the list, so if your post doesn't show up there I can send the patch from my address.

Comment 4 Daniel Novotny 2009-10-27 14:04:57 UTC
...now I see your mail in the upstream mailing list

Comment 5 Dave Malcolm 2009-10-27 14:15:00 UTC
(In reply to comment #4)
> ...now I see your mail in the upstream mailing list  
http://mx.gw.com/pipermail/file/2009/000483.html