Bug 531391
| Summary: | Review Request: gwsmhg - hg/mq GUI | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mads Kiilerich <mads> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.8.2-1.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-11-18 07:03:58 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Mads Kiilerich
2009-10-28 01:11:56 UTC
Well,
* debug_package
- "%define debug_package %{nil}" is not needed for noarch srpm.
! sed line for desktop
- I suggest to move "sed -i" line to %prep as
* Modifying text file by sed like this is like applying patches,
which is usually done at %prep
* And moving to %prep prevents this line from being called
with "$ rpmbuild -bc --short-circuit"
* Desktop file
- Categories "Application" "X-Fedora" are deprecated and should be
removed.
Thanks. FWIW I had set debug_package to nil to avoid find: `debug': No such file or directory but I can live with that ;-) X-Fedora isn't in the freedesktop menuspec whitelist, but is it in any packaging guideline blacklist? All comments are addressed in http://bitbucket.org/kiilerix/gwsmhg-rpm/raw/tip/gwsmhg.spec http://bitbucket.org/kiilerix/gwsmhg-rpm/downloads/gwsmhg-0.8.1-2.fc11.src.rpm One issue * Desktop file - Please also remove "Application" category. (In reply to comment #2) > X-Fedora isn't in the freedesktop menuspec whitelist, but is it in any > packaging guideline blacklist? - It is no longer used on Fedora (the discussion is rather old: http://www.redhat.com/archives/fedora-extras-list/2006-October/msg00723.html http://www.redhat.com/archives/fedora-packaging/2006-October/msg00188.html ) "X-Fedora" category seems remains on fedora.us age. Otherwise okay. --------------------------------------------------------- This package (gwsmhg) is APPROVED by mtasaka --------------------------------------------------------- ping? New Package CVS Request ======================= Package Name: gwsmhg Short Description: A PyGTK GUI wrapper for hg and mq Owners: kiilerix Branches: F-11 F-12 InitialCC: CVS done. gwsmhg-0.8.2-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/gwsmhg-0.8.2-1.fc12 gwsmhg-0.8.2-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/gwsmhg-0.8.2-1.fc11 Closing. gwsmhg-0.8.2-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. gwsmhg-0.8.2-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |