Bug 532241
Summary: | Review Request: emacs-identica-mode - Identica mode for emacs. | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Arun S A G <sagarun> |
Component: | Package Review | Assignee: | Michel Lind <michel> |
Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | fedora-package-review, michel, notting, shakthimaan |
Target Milestone: | --- | Flags: | sagarun:
fedora-review-
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | NotReady | ||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2012-01-21 20:15:10 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Arun S A G
2009-10-31 18:56:29 UTC
Testing the package: Add the following lines to ~/.emacs file ;;; Identi.ca mode for emacs (require 'identica-mode) (setq identica-username "username") (setq identica-password "password") ;; Add this to send status updates (global-set-key "\C-cip" 'identica-update-status-interactive) ;; Add this to send direct messages (global-set-key "\C-cid" 'identica-direct-message-interactive) How to: http://blog.nethazard.net/identica-mode-for-emacs/ obsolete entries in spec file removed Spec URL: http://sagarun.fedorapeople.org/SPECS/emacs-identica-mode.spec SRPM URL: http://sagarun.fedorapeople.org/SRPMS/emacs-identica-mode-0.8-2.fc11.src.rpm The SRPM link is invalid, though the spec still works. Unfortunately the spec is insufficient to recreate the package due to Source1, so this cannot be reviewed as is. Please clear the Whiteboard if you provide working links, thanks. (In reply to comment #3) > The SRPM link is invalid, though the spec still works. Unfortunately the spec > is insufficient to recreate the package due to Source1, so this cannot be > reviewed as is. > > Please clear the Whiteboard if you provide working links, thanks. SRPM URL: http://sagarun.fedorapeople.org/SRPMS/emacs-identica-mode-0.8-2.fc12.src.rpm Spec URL: http://sagarun.fedorapeople.org/SPECS/emacs-identica-mode.spec Updated to the latest version: (the info file needs fix) SRPM URL: http://sagarun.fedorapeople.org/SRPMS/emacs-identica-mode-1.0-1.fc13.src.rpm Spec URL: http://sagarun.fedorapeople.org/SPECS/emacs-identica-mode.spec Hi Arun, Sorry for the late reply! A couple of problems with the package right now: - incomplete Build Requirement: you're using makeinfo, which is supplied by the texinfo package - Upstream releases unversioned tarballs on their main download site, which makes it hard for someone to verify that the sources are accurate. Suggest contacting upstream, and meanwhile downloading the tarballs generated from the Git tags instead (see detailed comments below) Also, 1.1 is out now -- probably a good time to upgrade. * TODO Review [72%] - [X] Names [2/2] - [X] Package name - [X] Spec name - [X] Package version [2/2] http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Versioning - [X] Version number http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Version_Tag - [X] Release tag http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Release_Tag http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages - [X] Meets [[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]] - [-] Source files match upstream Upstream does not put the versioned source tarball in their download server; I suggest downloading the tarballs generated from the Git tags instead: http://git.savannah.gnu.org/cgit/identica-mode.git Contacting upstream is probably a good idea too, asking for the download tarballs to carry the version number - [X] [[http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries][No bundled libraries]] - [X] License [4/4] - [X] License is Fedora-approved - [X] No licensing conflict - [X] License field accurate - [X] License included iff packaged by upstream - [-] rpmlint [1/2] - [X] on src.rpm emacs-identica-mode.src: W: file-size-mismatch identica-mode.tar.gz = 31463, http://download.savannah.gnu.org/releases/identica-mode/identica-mode.tar.gz = 33026 1 packages and 0 specfiles checked; 0 errors, 1 warnings. This is due to the source file problem, see above. Otherwise fine - [ ] on x86_64.rpm - [X] Language & locale [2/2] - [X] Spec in US English - [X] Spec legible - [-] Build [2/3] - [-] Koji results http://koji.fedoraproject.org/koji/taskinfo?taskID=2978357 - [-] BRs complete makeinfo not found; needs to BR on texinfo - [X] Directory ownership - [X] Spec inspection [9/9] - [X] No duplicate files - [X] File permissions - [X] Filenames must be UTF-8 - [X] no BuildRoot ([[https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag][except if targeting RHEL5]]) - [X] [RHEL] %clean section https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean) - [X] [RHEL 5] %buildroot cleaned on %install - [X] Macro usage consistent - [X] Documentation [1/1] - [X] %doc files are non-essential - [X] Other subpackages - [X] [[http://fedoraproject.org/wiki/Packaging/ScriptletSnippets][Scriptlets]] [1/1] - [X] info files Hi Michel, Sorry for the late reply. Updated to git tag v 1.1 SRPM URL: http://sagarun.fedorapeople.org/SRPMS/emacs-identica-mode-1.1-1.fc15.src.rpm SPEC URL: http://sagarun.fedorapeople.org/SPECS/emacs-identica-mode.spec Ping Closing this. No one seems to be interested in reviewing this! *** This bug has been marked as a duplicate of bug 826483 *** |