Bug 532286
| Summary: | Review Request: treeline - Store almost any kind of information in a tree structure | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Thomas Janssen <thomasj> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bugs.michael, fedora-package-review, jsaucier, notting |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-01-27 21:40:42 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Thomas Janssen
2009-11-01 07:35:12 UTC
> treeline.x86_64: E: no-binary
I think you should add this to your spec file to specify that your package is not arch specific :
BuildArch: noarch
(In reply to comment #1) > > treeline.x86_64: E: no-binary > > I think you should add this to your spec file to specify that your package is > not arch specific : > > BuildArch: noarch Erm.. But you have seen that there's a -libs subpackage? -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers My error, excuse me, I didn't see the *fc11* in your rpmlint command. > have seen that there's a -libs subpackage? Yes. The package contents are .noarch nevertheless. And it's broken currently: $ sudo rpm -i treeline-1.2.4-1.fc12.i686.rpm $ treeline /usr/bin/python: can't open file '/usr/lib/python2.6/site-packages/treeline/treeline.py': [Errno 2] No such file or directory What's the rationale for this strange -libs split-off? > Requires: PyQt4, python, qt, aspell https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires plus: "qt" is redundant, and treeline doesn't need it directly anyway plus: "python" is redundant, because the Python ABI dependency is automatic for the treeline module > BuildRequires: python, python-devel, desktop-file-utils, dos2unix > PyQt4, qt, aspell Same redundancy here. python-devel requires python, PyQt4 requires qt The fix for --short-circuit builds: --- treeline.spec.orig 2010-01-04 22:58:05.000000000 +0100 +++ treeline.spec 2010-01-04 22:58:26.000000000 +0100 @@ -67,7 +67,7 @@ rm -rf %{buildroot} python install.py -b %{buildroot} -mkdir __doc +rm -rf __doc ; mkdir __doc mv %{buildroot}%{_datadir}/doc/%{name}/* __doc rm -rf %{buildroot}%{_datadir}/doc/%{name} I thought a long time about that package now, fixed it even. Jean-Francois, you were of course right. Michael thanks and sorry. It was one of my early review requests and my first python package. Confused me obviously a bit. Since i became the maintainer of two other solutions who fulfill the same functionality (basket, incollector), i lost the interest in that one. I will close it. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers |