Bug 532481

Summary: included hunspell copy has disallowed constructs with gcc -D_FORTIFY_SOURCE=2. Best to just use the system library
Product: [Fedora] Fedora Reporter: Caolan McNamara <caolanm>
Component: texmakerAssignee: Deji Akingunola <dakingun>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: high    
Version: rawhideCC: caolanm, dakingun, yaneti
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 507829 Environment:
Last Closed: 2009-11-02 15:39:41 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 507829    
Bug Blocks:    
Attachments:
Description Flags
here's a replacement texmaker-tools.patch which does the right thing none

Description Caolan McNamara 2009-11-02 15:11:48 UTC 
+++ This bug was initially created as a clone of Bug #507829 +++
--- Additional comment from dakingun on 2009-11-02 09:37:36 EDT ---

I'm re-opening this bug because similar problem is preventing texmaker from starting. Here is what I get when I tried to run texmaker in gdb;
... 
(gdb) bt
#0  0x00000031da433575 in raise (sig=<value optimized out>)
    at ../nptl/sysdeps/unix/sysv/linux/raise.c:64
#1  0x00000031da434d55 in abort () at abort.c:92
#2  0x00000031da470393 in __libc_message (do_abort=<value optimized out>, 
    fmt=<value optimized out>) at ../sysdeps/unix/sysv/linux/libc_fatal.c:186
#3  0x00000031da4faae7 in __fortify_fail (msg=
    0x31da540fb5 "buffer overflow detected") at fortify_fail.c:32
#4  0x00000031da4f8a50 in __chk_fail () at chk_fail.c:29
#5  0x00000000004ff3fb in strcpy (__src=<value optimized out>, 
    __dest=<value optimized out>) at /usr/include/bits/string3.h:106
#6  HashMgr::add_word (__src=<value optimized out>, 
    __dest=<value optimized out>) at hunspell/hashmgr.cxx:138
#7  0x00000000004ffc5e in HashMgr::load_tables (this=0xb76dc0, 
    tpath=<value optimized out>, key=<value optimized out>)
    at hunspell/hashmgr.cxx:474
#8  0x00000000004ffe32 in HashMgr::HashMgr (this=0xb76dc0, tpath=
    0xbaabd8 "/usr/share/myspell/en_US.dic", apath=<value optimized out>, key=
    0x0) at hunspell/hashmgr.cxx:52
#9  0x000000000050535a in Hunspell::Hunspell (this=0xb8a2b0, affpath=
    0xb74e58 "/usr/share/myspell/en_US.aff", dpath=
    0xbaabd8 "/usr/share/myspell/en_US.dic", key=0x0)
    at hunspell/hunspell.cxx:35
#10 0x0000000000470e1e in Texmaker::Texmaker (this=0xb82810,
Comment 1 Caolan McNamara 2009-11-02 15:12:58 UTC 
texmaker has a copy of hunspell inside it, its that copy which is crashing. texmaker should try and use the system library, not just the system dictionaries
Comment 2 Caolan McNamara 2009-11-02 15:21:26 UTC 
Created attachment 367152 [details]
here's a replacement texmaker-tools.patch which does the right thing

Replacing texmaker-tools.patch with this one will get it link against the (working) system hunspell instead of including in its own copy of the (broken) sources
Comment 3 Caolan McNamara 2009-11-02 15:24:45 UTC 
You'll need an additional BuildRequires: hunspell-devel and then the Requires: hunspell can be removed as it will get an appropiate autorequire after it links with libhunspell
Comment 4 Deji Akingunola 2009-11-02 15:39:41 UTC 
(In reply to comment #3)
> You'll need an additional BuildRequires: hunspell-devel and then the Requires:
> hunspell can be removed as it will get an appropiate autorequire after it links
> with libhunspell  

Yea. I've done that already, thank you. And thanks for the patch too.
Comment 5 Fedora Update System 2009-11-02 20:27:43 UTC 
texmaker-1.9.2-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/texmaker-1.9.2-2.fc11
Comment 6 Fedora Update System 2009-11-02 20:27:48 UTC 
texmaker-1.9.2-2.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/texmaker-1.9.2-2.fc10
Comment 7 Fedora Update System 2009-11-10 17:45:09 UTC 
texmaker-1.9.2-2.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 8 Fedora Update System 2009-11-10 17:56:44 UTC 
texmaker-1.9.2-2.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.