Bug 533141
| Summary: | Review Request: perl-CGI-Application-Plugin-DBIx-Class - Access a DBIx::Class Schema from a CGI::Application | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Emmanuel Seyman <emmanuel> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.093011-2.fc12 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-11-20 05:14:40 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Emmanuel Seyman
2009-11-05 10:44:05 UTC
Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1789541 - rpmlint is NOT silent for SRPM and for RPM. perl-CGI-Application-Plugin-DBIx-Class.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-CGI-Application-Plugin-DBIx-Class-0.093011/README perl-CGI-Application-Plugin-DBIx-Class.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-CGI-Application-Plugin-DBIx-Class-0.093011/META.json perl-CGI-Application-Plugin-DBIx-Class.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-CGI-Application-Plugin-DBIx-Class-0.093011/dist.ini perl-CGI-Application-Plugin-DBIx-Class.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-CGI-Application-Plugin-DBIx-Class-0.093011/LICENSE perl-CGI-Application-Plugin-DBIx-Class.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-CGI-Application-Plugin-DBIx-Class-0.093011/Changes + source files match upstream url fc3499c707002c21d1cc9008fcb49e9fe3140b2a CGI-Application-Plugin-DBIx-Class-0.093011.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=3, Tests=21, 2 wallclock secs ( 0.05 usr 0.01 sys + 0.79 cusr 0.04 csys = 0.89 CPU) + Package perl-CGI-Application-Plugin-DBIx-Class-0.093011-1.fc12.noarch => Provides: perl(CGI::Application::Plugin::DBIx::Class) = 0.093011 Requires: perl(Carp) perl(Exporter) perl(parent) perl(strict) perl(warnings) + Not a GUI application Suggestion: 1) Just add following line to %prep section sed -i 's/\r//' Changes LICENSE dist.ini META.json README This will fix rpmlint messages. (In reply to comment #1) > > Suggestion: > 1) Just add following line to %prep section > sed -i 's/\r//' Changes LICENSE dist.ini META.json README D'oh! Done. Spec URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-DBIx-Class/perl-CGI-Application-Plugin-DBIx-Class.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-DBIx-Class/perl-CGI-Application-Plugin-DBIx-Class-0.093011-2.fc11.src.rpm APPROVED Thank you, Parag. Requesting CVS. New Package CVS Request ======================= Package Name: perl-CGI-Application-Plugin-DBIx-Class Short Description: Access a DBIx::Class Schema from a CGI::Application Owners: eseyman Branches: F-10 F-11 F-12 InitialCC: perl-sig cvs done. perl-CGI-Application-Plugin-DBIx-Class-0.093011-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-CGI-Application-Plugin-DBIx-Class-0.093011-2.fc11 perl-CGI-Application-Plugin-DBIx-Class-0.093011-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/perl-CGI-Application-Plugin-DBIx-Class-0.093011-2.fc12 perl-CGI-Application-Plugin-DBIx-Class-0.093011-2.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-CGI-Application-Plugin-DBIx-Class'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-11175 perl-CGI-Application-Plugin-DBIx-Class-0.093011-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-CGI-Application-Plugin-DBIx-Class'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-11199 perl-CGI-Application-Plugin-DBIx-Class-0.093011-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. perl-CGI-Application-Plugin-DBIx-Class-0.093011-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. |