Bug 533763

Just a few notes:

Change Requires: texlive-latex to Requires: tex(latex).

If you're using braces around %{texpkgdir} use them also with %{buildroot}.

Spec URL: http://www.flyn.org/SRPMS/tex-cjw.spec
SRPM URL: http://www.flyn.org/SRPMS/tex-cjwltx-20090907-2.fc12.src.rpm

- Require tex(latex)
- Put braces around buildroot

A few comments as I look through these ancient review tickets:

The packaging looks fine; there's some stuff you can drop (Buildroot, %clean, first line of %install) on today's Fedora releases.

The upstream URL is 404 for me, as is the Source0: URL.

Not sure how the license comes out to LPPL; I checked for copyright statements and came up with the following (from cjw-latex.ins

=====
    Copyright (C) 1997 by:  Colin J. Wynne <cwynne.edu>

This file is part of cjw-latex, a collection of package files for
LaTeX2e, written by Colin J. Wynne.  It may be freely distributed in
any form---electronic, physical, or otherwise---so long as the
distributor provides this file in its entirety (including this
copyright announcement) and charges no fee (except for reasonable
recompense for the duplication process).  Fair 'nough?

I would also prefer that the entire source file `cjw-latex.dtx',
together with `cjw-latex.ins', be propagated instead of any one
subfile.

Please feel free to improve on or alter any code herein as suits your
needs, and by all means notify me of any suggestions, improvements, or
requests.

This file is beer-ware.  If you use it and like it, then you should
buy me a beer if you ever meet me. :-)
=====

There are also files with copyright statements but no license:

cjw-ltr.ins:
=====
Copyright (C) 1995 by Colin J. Wynne

This file is part of cjw-ltr, a class for creating modified standard
letters as well as German style letters under LaTeX2e.
=====

cjwoutl.ins:
=====
Copyright (C) 1995 by Colin J. Wynne

This file is part of cjwoutl, a package
for generating outlines with LaTeX2e.
=====

And so forth.  I'm not sure what that all comes out to, but I'm rather certain it's not LPPL.

I have a personal email from Colin. He agreed on the LPPL and said he'd update the source files. I never saw the changes applied to the files and now they do not seem to be available any more. I will contact Colin and ask him about this again.

Any update here? This review request is very old.

As per the stalled review policy please provide an update. If one is not provided in the next week this bug will be closed.

https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews

Well, Colin did not update the source file. I still have a personal email from him, but that is all. I just sent another email asking if he would be willing to update the source files to use the LPPL license.

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

This review request is still valid.

 - Not needed anymore

%defattr(-,root,root,-)

rm -rf %{buildroot}

Group:

 - Both sources and url seems defunct, there's a mirror here: https://ctan.math.utah.edu/ctan/tex-archive/macros/latex/contrib/cjw.zip

Spec URL: http://www.flyn.org/SRPMS/tex-cjw.spec
SRPM URL: https://www.flyn.org/SRPMS/tex-cjwltx-20090907-3.fc32.src.rpm

- Remove use of defattr
- Remove rm -rf of buildroot
- Remove use of Group
- Update Source0

 - Spec filename and bug report should match the SPEC name:

Name:             tex-cjwltx


 - Use global not define

  - %{!?_texmf: %define _texmf %(eval "echo `kpsewhich -expand-var '$TEXMFMAIN'`")}

 Use the predefined macros:

%_texmf_main = /usr/share/texlive/texmf-dist

%global texpkg    cjwltx
%global texpkgdir %{_texmf_main}/tex/latex/%{texpkg}
%global texpkgdoc %{_texmf_main}/doc/latex/%{texpkg}


 - Run the Texlive macros:

%post
%texlive_post

%postun
%texlive_postun

%posttrans
%texlive_posttrans

Spec URL: http://www.flyn.org/SRPMS/tex-cjw.spec
SRPM URL: https://www.flyn.org/SRPMS/tex-cjwltx-20090907-4.fc32.src.rpm

- Use global, not define
- Use predefined macros
- Run the TeX Live macros

 - Spec filename and bug report should match the SPEC name:

Name:             tex-cjwltx


Choose either tex-cjwltx or tex-cjw. Make all the same name: the SPEC filename, and this bug title as it will determine the repo name too.

 - Can safely remove this now:

%{!?_texmf: %global _texmf %(eval "echo `kpsewhich -expand-var '$TEXMFMAIN'`")}



Package is approved but you need to choose the name you are going to use *before* requesting the repo.




Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Spec file name must match the spec package %{name}, in the format
  %{name}.spec.
  Note: tex-cjw.spec should be tex-cjwltx.spec
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#_spec_file_naming


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[-]: License field in the package spec file matches the actual license.
     Note: There is no build directory. Running licensecheck on vanilla
     upstream sources. No licenses found. Please check the source files for
     licenses manually.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[ ]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Bad spec filename: /home/bob/packaging/review/tex-cjw/review-
     tex-cjw/srpm-unpacked/tex-cjw.spec
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: tex-cjwltx-20090907-4.fc33.noarch.rpm
          tex-cjwltx-20090907-4.fc33.src.rpm
tex-cjwltx.noarch: W: description-shorter-than-summary
tex-cjwltx.noarch: W: no-url-tag
tex-cjwltx.noarch: W: no-documentation
tex-cjwltx.noarch: W: dangerous-command-in-%posttrans rm
tex-cjwltx.src: W: description-shorter-than-summary
tex-cjwltx.src: W: no-url-tag
tex-cjwltx.src: E: invalid-spec-name
2 packages and 0 specfiles checked; 1 errors, 6 warnings.

Spec URL: http://www.flyn.org/SRPMS/tex-cjw.spec
SRPM URL: https://www.flyn.org/SRPMS/tex-cjw-20090907-5.fc32.src.rpm

- Simplify package name to cjw
- Remove texmf definition from first line of specification

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/tex-cjw