Bug 533803
| Summary: | Review Request: libcue - CUE sheet parser library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Lemenkov <lemenkov> |
| Component: | Package Review | Assignee: | Michael Schwendt <bugs.michael> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bugs.michael, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | bugs.michael:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.3.0-2.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-12-01 04:15:27 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Peter Lemenkov
2009-11-09 09:52:33 UTC
* "Group" tag of base package should be: System Environment/Libraries * Source URL points at a web page instead of the source tarball. Use this (it follows the guidelines, too): http://downloads.sourceforge.net/libcue/libcue-%{version}.tar.bz2 > %description > Libcue is intended to parse a so called [...] Correct English IMO would be: Libcue is intended for parsing a so-called [...] > W: shared-lib-calls-exit /usr/lib/libcue.so.1.0.3 exit Not good, since this is a library. Libraries ought to return error values instead of terminating the process. This exit call is in a fatal error function inside the generated flex scanner code. * Two source files rem.c and rem.h contain a BSD license header and the name of the current developer. According to Fedora's Licensing Guidelines, this must be reflected in the "License" tag plus a comment in the spec file: # Files libcue/rem.{c,h} contain a BSD header License: GPLv2 and BSD https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios The project's file "COPYING" comments on the two licences and explicitly acknowledges that the whole libcue project uses the GPLv2. Preferably, the current developer removes the ambiguity and explicitly applies the GPLv2 inside the rem.c/rem.h files, too. Fi(In reply to comment #1) > * "Group" tag of base package should be: System Environment/Libraries Fixed. > * Source URL points at a web page instead of the source tarball. Use this (it > follows the guidelines, too): > http://downloads.sourceforge.net/libcue/libcue-%{version}.tar.bz2 Fixed. > > %description > > Libcue is intended to parse a so called [...] > > Correct English IMO would be: Libcue is intended for parsing a so-called [...] Fixed. > > W: shared-lib-calls-exit /usr/lib/libcue.so.1.0.3 exit > > Not good, since this is a library. Libraries ought to return error values > instead of terminating the process. This exit call is in a fatal error function > inside the generated flex scanner code. I'll sent a message upstream regarding this issue. > * Two source files rem.c and rem.h contain a BSD license header and the name of > the current developer. According to Fedora's Licensing Guidelines, this must be > reflected in the "License" tag plus a comment in the spec file: > > # Files libcue/rem.{c,h} contain a BSD header > License: GPLv2 and BSD Fixed. http://peter.fedorapeople.org/libcue.spec http://peter.fedorapeople.org/libcue-1.3.0-2.fc12.src.rpm With those changes, libcue-1.3.0-2.fc12.src.rpm is good to go: APPROVED [...] Note that in Fedora 10 and newer you can omit: * the BuildRoot tag * removal of buildroot at beginning of %install * the entire %clean section Plus in current Fedora 11 and later, there are automatic pkgconfig dependencies. So on those platforms, the "Requires: pkgconfig" is redundant. Thanks! (In reply to comment #3) > With those changes, libcue-1.3.0-2.fc12.src.rpm is good to go: > Note that in Fedora 10 and newer you can omit: > > * the BuildRoot tag > * removal of buildroot at beginning of %install > * the entire %clean section > > Plus in current Fedora 11 and later, there are automatic pkgconfig > dependencies. So on those platforms, the "Requires: pkgconfig" is redundant. I plan to provide libcue for EPEL too, so in order to simplify maintenance, I won't delete all these redundant tags, at least until EPEL will get our new rpm and support for EL-5 will be dropped :) New Package CVS Request ======================= Package Name: libcue Short Description: Cue sheet parser library Owners: peter Branches: F-11 F-12 EL-4 EL-5 InitialCC: cvs done. libcue-1.3.0-2.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/libcue-1.3.0-2.el5 libcue-1.3.0-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/libcue-1.3.0-2.fc12 libcue-1.3.0-2.el4 has been submitted as an update for Fedora EPEL 4. http://admin.fedoraproject.org/updates/libcue-1.3.0-2.el4 libcue-1.3.0-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/libcue-1.3.0-2.fc11 libcue-1.3.0-2.el4 has been pushed to the Fedora EPEL 4 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libcue'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-4/FEDORA-EPEL-2009-0899 libcue-1.3.0-2.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libcue'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0904 libcue-1.3.0-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libcue'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-12113 libcue-1.3.0-2.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libcue'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-12194 libcue-1.3.0-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. libcue-1.3.0-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. libcue-1.3.0-2.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report. libcue-1.3.0-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |